[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/4] xen/arm: bootfdt: Make process_chosen_node() return int
- To: Henry Wang <Henry.Wang@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Mon, 5 Sep 2022 11:16:32 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jtmLFL+3KZ8xG33Tl3+dVb7YfA4SCCuaU6TuGlBgmlw=; b=SiIXkCVxq8yq4rVXoH+ZTqzBGC2stwpbMdbPjtMzuYCbDAw8pj0tJ14MBDfup5jg8unxjrEZQ1r8Y1SjyYMuAmuiGR7mzezguqn17fLdJYCUud7qp98hsV5BixX4bIZHb2/uRSCCamUKkKTIFkNfHpMiemfSBzW1egxN/VYmwjpz3o/IvkF/cdKKkHnIPL5uojdXEI296euBX5EvnkpGNDcxee9oosaHqjH6f2IHEFkdhhKQtSKPlXWWFW/UE2cMG8GidPP3J9T+CZQ0h3OWrjNkO3Zr2UNq47pUrKuFxyV0aO6shU3xkzD5EFPrZU/Hmjikgw9JytpNUCuDPF15wQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hLgeAxttNn54vlxZWAB5m37D8eq/zgvWYN6WKgxC8aPxQlGoIgCd5LMs/dWKJBlv20939reHy0Ot6pihvgFnLTvLtWtkv94frQ6JVVIiPmfB5zHMvM/+8SPo5BGBPWTvL6gaqBj0DOIUHWDolXNvC+MmB6LvByu7nePLbaGUbfp2+vYMGV0fCoQvHqbWiHISIAOLO42SeB1YUfe/OzrtD1zVWd6bpxLjERzZlF8Ip0lG1oHBhuVYTDeVzm2MMR9wM+/Rz51QFl0+qqePN3ZUyoqvamSnYHgmqb7O+5lGPZW56VONJOAI2T7Tz3aGOo1v2WErYfkWiCO1fj9dGOmv9g==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Wei Chen <wei.chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 05 Sep 2022 09:16:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Henry,
On 05/09/2022 09:26, Henry Wang wrote:
>
> At the boot time, it is saner to stop booting early if an error occurs
> when parsing the device tree chosen node, rather than seeing random
> behavior afterwards. Therefore, this commit changes the return type of
> the process_chosen_node() from void to int, and return correct errno
> based on the error type.
>
> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
> ---
> Changes from v1 to v2:
> - New commit.
> ---
The patch looks good but I think it should be put as the first one in the series
as this is a natural prerequisite for the introduction of the reserved heap.
This
will also help not to modify the same reserved heap code you introduced in the
first patch.
~Michal
|
