[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 16/37] xen/x86: export srat_bad to external


  • To: Wei Chen <Wei.Chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 27 Jan 2022 09:37:20 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qrR5IIovUV8hqi7Wt/gCp+G+J9JQRpJy2jVPcWNFArc=; b=HVcR1ytmp2L/1j98DGwfLQfzABLXk2mxcCDmGtRRwORchXyfHDrIZoLcXlVnHZB/Yl7VO84eVj6e8m2YtDCFej5yg2EQwFWq8f3pEcY+vZfJp0wRRQ+OoXYWJBuiksZcewKw4l8pp02+jzZTFB8SYrEh/gAc0KxoQhXwfncYHGaUnvdUnAJouYN4l07H5HJKWGCya3CIT+6appiz98Fd+M2crUryUkJ3eu6IZlI4daC2+8noK8VtHsn1AHm3wGL/azajLCk2quSCI17YY8c7wr94vTXAwd9AbZhXszDphJB7N+/2iW5cgSTGLCmDa/eJt1XV6PdHx6iz1uEq90TmmQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i3LPhXMhVGWe/qft570zunPQDKYBM8RSJWyWbjseN/X4k2ubCh/USpt0yUmKL57650O3wMhEZ/J8hQGv8YScWMtWfpXALvxFRlE9/4yyFF3nfQkGIBI5ekfERtddBqscqT+bj23drggp6pIa6bPUGETvuu38u1HaNT6qJIWAzdwR78TUxGIv/0rvhBmHfWv8SGI1lai0LxtT/75xfN59daF7bsF3+TRV8qQDEwT3XS+5tup22sLLa7Io6L8A8KLsu+xopNOalzQvY75ukAOrFEJ3Pefg6zjmNMMx2ip0XzaSu5xT/Npo0EvkhPcZ447nQZeBZ0UDxL4cs+xwwqTqsQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
  • Delivery-date: Thu, 27 Jan 2022 08:37:28 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 27.01.2022 09:35, Wei Chen wrote:
> Hi Jan,
> 
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 2022年1月25日 18:22
>> To: Wei Chen <Wei.Chen@xxxxxxx>
>> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
>> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
>> Subject: Re: [PATCH 16/37] xen/x86: export srat_bad to external
>>
>> On 23.09.2021 14:02, Wei Chen wrote:
>>> srat_bad is used when NUMA initialization code scan SRAT failed.
>>> It will turn fw_numa to disabled status. Its implementation depends
>>> on NUMA implementation. We want every NUMA implementation to provide
>>> this function for common initialization code.
>>>
>>> In this patch, we export srat_bad to external. This will allow to
>>> have the code mostly common.
>>
>> Here as well as in the subject it would help if the function name
>> wasn't the wrong way round. I also don't see how you mean to use a
>> function containing "srat" in its name from non-ACPI code.
>>
>> Perhaps alongside numa_mode() (see the reply to the earlier patch)
>> you want to have a set_numa_off() helper (name subject to
>> improvement)?
>>
> 
> Yes, actually, I want a function to disable the numa when we encounter
> any error in numa initialization. And we also so want to indicate the
> numa off is caused by configuration error. So we had thought to use
> numa_fw_fault to replace srat_bad.

Why not simply numa_bad() or, say, numa_disable()?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.