[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 16/37] xen/x86: export srat_bad to external


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Wei Chen <Wei.Chen@xxxxxxx>
  • Date: Thu, 27 Jan 2022 08:47:33 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6w9JL6lBnKDmDtI9N0cPUQ3IpG1eflaM/TnQ7PivLzY=; b=QkpjM+8m8yoMHn8HYBkcYWJHX6+W+FHwugzFlq2rft0Z2olYxOSxezDfKUxx4/sdpLVH+AGOaFn+pYDd3ysYxbLb4ychW8+TRE3qB2RH2HWxy36Up+vy+A/YCqHobbIXdoY3zUG985s5+x94OzZn2tzQ5u5xFWfqSSN1Vc5ugZH6FSzB+xl2LMVenlIHK7ys5AkXx5lF1FEU8J43nnQ0KnvY2Mbw7BF3Gutylq2UTVS8cDvIar95SAIG88dtMfEmU9wxN7o8KhBsStcKBPORoigtxZdwdwPnlfEicJmqRUFYjwKhEfRCcSZbTwKVfUNx8axyH6rQgZg/IYmGgXxAVw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nGIzTikE902Rax/C4KrDpwaNIIFtzVG+Dskt9ycIwZRCktUYmvTpu1xtNITwnfnmxo2FXtspwmKtOo/OCjf4ULlZcC62MS1xVL2yTGQmhNilDsfVV8dOzYDaXPMFm0C4kvobu0On5oaohr3Lh9KySxz7FPlk9OmR9qb9H54fLWHYY36ar0SJJpnA4sQ9UPz0faR5u1VtuzRDT0xJ2TkUJUB7IZ1rhQmuQmkp8jfBvKOyNb4dgpqOFsNc7a66KvBC3QCPgGjjrMjAgiG6OdgaEGsz3yGStT/C4nWwGKHBoOQreWZsv+U4cvHK5wCrJQjL8vCydzvgzBiWwP5Ov1RBQg==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
  • Delivery-date: Thu, 27 Jan 2022 08:48:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXsHMnFy02K9wv1EmfXGO37i6/5qx0SfuAgAMEmKCAAAK4AIAAAm5w
  • Thread-topic: [PATCH 16/37] xen/x86: export srat_bad to external

Hi Jan,

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年1月27日 16:37
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> Subject: Re: [PATCH 16/37] xen/x86: export srat_bad to external
> 
> On 27.01.2022 09:35, Wei Chen wrote:
> > Hi Jan,
> >
> >> -----Original Message-----
> >> From: Jan Beulich <jbeulich@xxxxxxxx>
> >> Sent: 2022年1月25日 18:22
> >> To: Wei Chen <Wei.Chen@xxxxxxx>
> >> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> >> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> >> Subject: Re: [PATCH 16/37] xen/x86: export srat_bad to external
> >>
> >> On 23.09.2021 14:02, Wei Chen wrote:
> >>> srat_bad is used when NUMA initialization code scan SRAT failed.
> >>> It will turn fw_numa to disabled status. Its implementation depends
> >>> on NUMA implementation. We want every NUMA implementation to provide
> >>> this function for common initialization code.
> >>>
> >>> In this patch, we export srat_bad to external. This will allow to
> >>> have the code mostly common.
> >>
> >> Here as well as in the subject it would help if the function name
> >> wasn't the wrong way round. I also don't see how you mean to use a
> >> function containing "srat" in its name from non-ACPI code.
> >>
> >> Perhaps alongside numa_mode() (see the reply to the earlier patch)
> >> you want to have a set_numa_off() helper (name subject to
> >> improvement)?
> >>
> >
> > Yes, actually, I want a function to disable the numa when we encounter
> > any error in numa initialization. And we also so want to indicate the
> > numa off is caused by configuration error. So we had thought to use
> > numa_fw_fault to replace srat_bad.
> 
> Why not simply numa_bad() or, say, numa_disable()?
> 

numa_bad would be OK.

> Jan


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.