[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 17/37] xen/x86: use CONFIG_NUMA to gate numa_scan_nodes


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Wei Chen <Wei.Chen@xxxxxxx>
  • Date: Thu, 27 Jan 2022 08:37:54 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ffCIXkpnW1uuM+j8VKF6KFjEz58l8eDshhdQpFdWj78=; b=VPNkNsMiRKXXx57NWpkxsq6JN2NPho4EJ21D8SkpvwbvFxk8MgYejHWkJ5WvxFVuOWejvkWP0vp+6BSQca0z+pZOBcgw50qDl+Gr8yt2zrm4bQLXO7iEmWR8OP4K+qd0fkpH3ZubLzglM69HGPpXVK7vZu48TX6HoTVgvs52MV9DFdA0nLR3Cff/mqa4goBaF1Uaa5bUAARziu27B4sRdA/SvRiCrgb5BB42vPr0+79YEEr6R/9RLdpCazOpo9nn31x0D9fxEvglr29uqR1KOrvWnAsocbOnlnpd7dzoMfiBoXJUwZIEOyQH4k3QBeAxa3e4aDLnenbgOr9tYcyBhA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UIEdu8CPPnvPPfISBT3OU9ty5hqqWeiyDsu3DXS+IeDhjt3k/MXnma6O0jns18DVxbSz0xnXIV9X/6HO53NIokjKz1Rb7H5yisNRDWhNFz1o+oALItmXycWP1WLuyxWpEggCF+V7yAvf4oPnsTk5up6RS7dbhKdC2rB1HVT9D/dqr8Vy5CUfbI4r9S7Ub1vvM3wqgeMjug/h1ie3E2w+R5fqRVnEeXWGKaEsSFPe5bt9x07R9a3CYaZmkteC/ErK/odalpvchtUk34HaPhGTw5KrVyk6PYrdsYaZXsrSceZahZ2TxHnai2HzDh8zO/XvtWr2UmLB9kmgI7ZRo1DHCg==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
  • Delivery-date: Thu, 27 Jan 2022 08:38:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXsHMdGsr4qfVkUkOsqMTqurczg6x0SxEAgAMGQfA=
  • Thread-topic: [PATCH 17/37] xen/x86: use CONFIG_NUMA to gate numa_scan_nodes

Hi Jan,

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年1月25日 18:26
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> Subject: Re: [PATCH 17/37] xen/x86: use CONFIG_NUMA to gate
> numa_scan_nodes
> 
> On 23.09.2021 14:02, Wei Chen wrote:
> > As we have turned numa_scan_nodes to neutral function. If we
> > still use CONFIG_ACPI_NUMA in numa_initmem_init to gate
> > numa_scan_nodes that doesn't make sense. As CONFIG_ACPI_NUMA
> > will be selected by CONFIG_NUMA for x86. So in this patch,
> > we replace CONFIG_ACPI_NUMA by CONFIG_NUMA.
> >
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > ---
> >  xen/arch/x86/numa.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
> > index 8a4710df39..509d2738c0 100644
> > --- a/xen/arch/x86/numa.c
> > +++ b/xen/arch/x86/numa.c
> > @@ -260,7 +260,7 @@ void __init numa_initmem_init(unsigned long
> start_pfn, unsigned long end_pfn)
> >      start = pfn_to_paddr(start_pfn);
> >      end = pfn_to_paddr(end_pfn);
> >
> > -#ifdef CONFIG_ACPI_NUMA
> > +#ifdef CONFIG_NUMA
> >      if ( !numa_off && !numa_scan_nodes(start, end) )
> >          return;
> >  #endif
> 
> Why is this a separate patch, rather than part of the one renaming
> the function?

I will merge these two patches.

> 
> Jan


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.