[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/37] xen/x86: decouple nodes_cover_memory from E820 map
- To: Wei Chen <Wei.Chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 27 Jan 2022 09:08:35 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aQe/dzEj1K/ID9RES+XuKb/Gq+hmTUITyTvoEVOB4z8=; b=LKgvzCBlvqBvtnsP6EoDs1fS+C6AVKvQFOmwQrN7aAGAfaHWUaqHI5GBzTo4HTHg6FPl5aWcNndvBjvc2sleq8FOGsuj7llJJdUvdJHUrMBm42AfFix9HMiaw2S5wykaGi89MBwzDebD98fHAKwvNJveHzrm85+jgHA1Cao5wwdUhzOUFg70z8qg4p8kxVYgqFEFrC0Eryyhu9MZ7Pp1ltf16YBG2JlH7v0OT6R4cNM3fHzkv+ed9u7+NoDipiz6F3V7f50YrYYq3ooHHJo/edVDmyfjVKNJcsclgiOo3Gn+cIhD1xsRsTa82FziZ6mUfn4Qus73SXNKb0zmjwmDWw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KVjthuX/wbdfasJeN8lafWq9XDU3M3ZO3IbxrJbSd55R2bNp0PJltUxFX6pangP6HsbSsA+AyhTJh6WG2BeHaLMPt6Qy+QowL2MlY2ef6TJYAgsC6KoyQa7BcYIytLFhCkiHuG7P0q9RyQjXlZ1qO0XpLeyW7d/Qgxzo9MadnTHzDbyiebhJjjaUU8zmXkhFQ0yF/WypcFUGnARXA3a+cbGvf2SYjH+M0KWHFQC8NmVHIqi0UT3vQRx7TjViwamfa3ETDrIC+1FKmMcl6t0pV4kqpyg2VPpgKDtckzST1w6B5PDKkC1pqXWd2t3JNrZnbkvqnVPo7DciX7a2MOlLhA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- Delivery-date: Thu, 27 Jan 2022 08:08:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.01.2022 09:03, Wei Chen wrote:
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 2022年1月25日 0:59
>>
>> On 23.09.2021 14:02, Wei Chen wrote:
>>> We will reuse nodes_cover_memory for Arm to check its bootmem
>>> info. So we introduce two arch helpers to get memory map's
>>> entry number and specified entry's range:
>>> arch_get_memory_bank_number
>>> arch_get_memory_bank_range
>>
>> I'm sorry, but personally I see no way for you to introduce the term
>> "memory bank" into x86 code.
>
> In my latest changes, I have updated these two helpers to:
> uint32_t __init arch_meminfo_get_nr_bank(void)
> __init arch_meminfo_get_ram_bank_range(...)
> I am sorry, I forgot to change the commit log accordingly.
> I will update it in next version.
I'm sorry for the ambiguity of my earlier reply, but my objection was
against "bank", not "memory". As an aside, you also don't want the
function return "uint32_t" - see ./CODING_STYLE.
Jan
|
