[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 13/37] xen/x86: decouple processor_nodes_parsed from acpi numa functions
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Thu, 27 Jan 2022 08:06:12 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FzkYhBh25GyKcBuErLDPSNPnUiG+lvDCA0kKw38c57Y=; b=aOoimM8BjxQcr/uqq1ExrEg6e7F3xupV+iFNQM5QujePtUPytZ/FWRYeRParPxbLL4VP0dD7lKNeB4oIMnAkDt1Mw7ExSgaV00Psqw7MKWuPI2FvXx9FMi8O2Fi0mMO1HaK5j4Hz07ejgIjhxp7o673Dj/h8JdEiJyYFDiLeELtYs/CqCbrSRRA52DdxJFSkZK8d3p7NzcUZVKkBMHCTo2thlDAGjylon8ZHU7l9Js1tXWbRdWDblHqxXSEbTpic3nMkX4TbjZRjlJccM220YIRucwqlECGQxlZ0jT7VBiWq6YooStRoOSvS+CXrJp+AwwTSViF6joiP5UnkIKGkxg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ee3xJ0Sg30VlWaufo1IHAVuFMPopXc6ihhoJgZXh8tMrIHO/MhjuHk9LhuQpxr9c6EL+awG6cydZeH19f4Ze7B5BGiA6DDJTz+O7lkG/89oVHKt8oFnCSI1mlXFF03pIzSFi2W3ll7MkVBBl6Nm8aos07U1b0bT+mM4s/56nIUwVlULeGk76GPPPMrYBoxdC1uvRDrfz6XgmXdrTT3C1qmKWk9uKs8D2nOYnMrDRLnrYx2Wa+/otbNoj/TOUBPGUUZlCm5E43un0cwjg9h40xd6t44H2D2YlYaB2o6/3Ptfmp1LlD6a9o8Ibukp+yF/Tx3vyCHGaogt1jIGxUu/wWg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- Delivery-date: Thu, 27 Jan 2022 08:06:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXsHMSdKhLEbfZMUSB+hDEcZc+16x0QMkAgAMHpwA=
- Thread-topic: [PATCH 13/37] xen/x86: decouple processor_nodes_parsed from acpi numa functions
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年1月25日 17:49
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> Subject: Re: [PATCH 13/37] xen/x86: decouple processor_nodes_parsed from
> acpi numa functions
>
> On 23.09.2021 14:02, Wei Chen wrote:
> > --- a/xen/arch/x86/srat.c
> > +++ b/xen/arch/x86/srat.c
> > @@ -104,6 +104,11 @@ nodeid_t setup_node(unsigned pxm)
> > return node;
> > }
> >
> > +void __init numa_set_processor_nodes_parsed(nodeid_t node)
>
> Besides (nit) the stray blank here, earlier comments apply. The way you
> do the rearrangement it is close to impossible to see the actual "why"
> behind the changes. Even if it would make for a bigger patch, I think
> you want to collapse patches and move things out of srat.c code while
> you split out generically usable functionality. Or, if the result was
> deemed to large a patch to have all in one go, make the movement of
> individual static variables the topic of each patch, introducing
> accessor functions like the one here.
>
Thanks, I will fix them in next version.
> Jan
|
