[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/37] xen/x86: decouple processor_nodes_parsed from acpi numa functions
- To: Wei Chen <wei.chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 25 Jan 2022 10:49:28 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QurmTp/BK5M5HtslKHeLN4tmyjSdaBdsVwT2JMCh/wk=; b=E27dhtiKYPHjybVe528L/AFuvA3zGkiSMfGYtrSYKPGtCF9BJdADvM5ZFQF+artG0TLK2VX625B+t6x5ef7hNfrpOLVZ41OZ+FzJbmFMLexWPs3rnNefs0iX1GKn6CTPN3DqbTxpwR9lg+MITUln2LoQfNV+EOvt85IQwkehbKSt1QUiNo7/8Rx5V6hP7mhro2/weIs2PfQR7shS4C4qHnntTcVumdbNaaL6yB0OFyf+jS5vM3zR242hBBcG57ywng1EaZUkiDvuA5VuMBvazv+kk2Jx/aowCRpKOSBLM2AusnYVv9o+FkZD5PmWr5xUcJhe9VohW20/twYeesHhjg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WyRXv18zT4xAosJKcKvEWAq8igSUtT553I+U3XfgtF6O3a8gWYLAnLUAGhlpXN9bj+w+7+sYUy6BDmYcXIP2eyOaGOlHFz/T4/HUx9O4QboxGTW4DCYShfWX0iP4mVyx2M0a6KzLxqPm02FJdWW2MvP33xbZcG81eOLY6RvELnP0Iwn5UUrWCi3ukH/MqeB+RkL7AA0lXIAviYI8PmMp3x/Ixmlicu98PlQ0aKJhKbcrN7w+GM95eObdpU8T8ys6Ys3iW+ePmA9aBwfXB2J4zlw5zdoua2lvrW1bSkTeCUlJk6+x3KYTl/VE7b/TqjM8s7KTNBGVwj311401i5wAUg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bertrand.Marquis@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, julien@xxxxxxx
- Delivery-date: Tue, 25 Jan 2022 09:49:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.09.2021 14:02, Wei Chen wrote:
> --- a/xen/arch/x86/srat.c
> +++ b/xen/arch/x86/srat.c
> @@ -104,6 +104,11 @@ nodeid_t setup_node(unsigned pxm)
> return node;
> }
>
> +void __init numa_set_processor_nodes_parsed(nodeid_t node)
Besides (nit) the stray blank here, earlier comments apply. The way you
do the rearrangement it is close to impossible to see the actual "why"
behind the changes. Even if it would make for a bigger patch, I think
you want to collapse patches and move things out of srat.c code while
you split out generically usable functionality. Or, if the result was
deemed to large a patch to have all in one go, make the movement of
individual static variables the topic of each patch, introducing
accessor functions like the one here.
Jan
|
