[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 12/37] xen/x86: decouple nodes_cover_memory from E820 map
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Thu, 27 Jan 2022 09:03:13 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=juXz+M71dQnfP5HVhsfEK2tSXWFozxA3q5U/+LaYu/0=; b=bXM2ZPqKKePNFIxjBv5A0hDQu9DEb+5XIhyOX6/k1jAO3GAWM7x7JQS43CbkJ0pppci0Mw7Cb6AOk0DrGFweUkCu2mq8OMZUbh2T971SXcsxOd0WNuOkGUKUUrMcW1WfMSKgRgKcNkSQ1B55qCUyVnW7JF//PvraV3GGGN2fIfjuH7MI1zM0jevixxUxOBTbpHF1hb3qWUAgAEv3C3LL3JX6dBg11LCzsOL1sqpw6HghEzwLazBaDFVL2lbpK0LHqd9VYOt4fqwxvCh2LlvyuTHgSlHYJmk1twy5w+pVfBnUrxASrE94RRrPV+BSZ9QblRef7g/nGM0C5FaLZn9zYA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hdhvwYZYrHLlKzLXTPQGk9LmWVStsz+7Nbt69QVjeqd7V3swBR89Aj7KowpFQlnp0oHbombk7saeVpM08gnpjOoMDmi4eCPE4yzRDU3qKAdKxxqdKcbCZ5Gdcmoh6mGnCnzfEKakAAMZQJQRXq9xoSZN0E4SInHMhWgyGzvC9/oDP4GWbidABeOQ7cKb1k56CHdVTB6tz14celr4Eo8VaMGVmj4XsPdtYjLVssclEH3UHRjLoRirIl2GQKESFDgWAmdF20AV9eeajdYOxgS3a7V+1+SjNelo1mexu0YoP820dghDMFR/bnfkSc+wDPvqh+qicoknnX0KhMn7ugJ06g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- Delivery-date: Thu, 27 Jan 2022 09:03:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXsHMWLK2Lk+nkCEuQGshEHTFFNqxzJoSAgAQcdmCAAAZJgIAADE6g
- Thread-topic: [PATCH 12/37] xen/x86: decouple nodes_cover_memory from E820 map
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年1月27日 16:09
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> Subject: Re: [PATCH 12/37] xen/x86: decouple nodes_cover_memory from E820
> map
>
> On 27.01.2022 09:03, Wei Chen wrote:
> >> From: Jan Beulich <jbeulich@xxxxxxxx>
> >> Sent: 2022年1月25日 0:59
> >>
> >> On 23.09.2021 14:02, Wei Chen wrote:
> >>> We will reuse nodes_cover_memory for Arm to check its bootmem
> >>> info. So we introduce two arch helpers to get memory map's
> >>> entry number and specified entry's range:
> >>> arch_get_memory_bank_number
> >>> arch_get_memory_bank_range
> >>
> >> I'm sorry, but personally I see no way for you to introduce the term
> >> "memory bank" into x86 code.
> >
> > In my latest changes, I have updated these two helpers to:
> > uint32_t __init arch_meminfo_get_nr_bank(void)
> > __init arch_meminfo_get_ram_bank_range(...)
> > I am sorry, I forgot to change the commit log accordingly.
> > I will update it in next version.
>
> I'm sorry for the ambiguity of my earlier reply, but my objection was
> against "bank", not "memory". As an aside, you also don't want the
How about arch_meminfo_get_nr_map/ arch_meminfo_get_map_range?
I am sorry, I am not very familiar with e820 map, could you
give me some suggestions?
> function return "uint32_t" - see ./CODING_STYLE.
OK.
>
> Jan
|
