[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] NetBSD hotplug: fix block unconfigure on destroy
- To: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 27 Jan 2021 10:40:43 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DqbFHMqdSeAud9UE3X6HcdVeifsYJofWryRws/2/CXo=; b=SB9Y/BDVt3b937C1PHszyMGvBLeIiH0q5hDWqnMg/X6cQZErLLizKVOUGqZVTUDhVYe6aBaf9OJzc7n3tLjJevOioJZGGP/FyuIOGIZnGkUqPn5gDpx6MBNdLXfX6kE0nObKftWNpBpKSptfJu19Ig1cmna3JPFp34fJ+0YmaknSbbBPPtSE1Y0Ghf3e1xd1m2QHO1nM1+j1qWdhqOxXTo6/pFZyV7/+C+FJzoqzotzSsFf4G5wNhHZ27cz1YR7b9tRO4RVl/EyIURjzfG7fAxvYijHTFODo9D2oGvXv0c2g2pWqhe99bHVMt1zwllvrffunyO6axvlHv5z9lGq2sw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hf/WLNRz+BRYH1IXf/8QVu5K217eO4A+O2vJRMgXXBW36TkOzPsXe1mkBZ7CxSQtBpaiB87D75Obi6iKOeQXMKqN5uZIr+i0OeFFitRzJwTKINznmTf1FFgbVzKBlDUHDjOSZkmNZe0Cc9dKm48kdPiExfixEa8tPH/t9BM02pNRvdGVYO5cR8Uwrg1BRntOLNIqt7dRz33oshCeO9f1kWxb57A3w8ZUs+rqxOEtZAIUG5JuPTzM5xkTsYsWJQel4VuIozh7fCXPlGfMN1YuUgex3W55fd5R7wMR7iBzuk+7Rjd9TZ5ODX/eUzdaHAemnnHfZHYGMC43PiBKHvNzdg==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 27 Jan 2021 09:41:11 +0000
- Ironport-sdr: VdIqnJZpSmfSfX0u5bJKJ3soAzeqdLRNkZvK35qIfT287Zp+aBOamJfJ5wclsTvYJFJczxKnlW BtEbcMqNIcl/pQ//T1ThWwTpP/9AtnA+NYuspT7DQHR+J72x6+c7OkxkNVdg8BcL0AwRE1dHKl 6JfLQCzNKW5Wjnm2l0Mphdys4+HVwe4UN/htc2CTDSRfdr4eNu99OFspbz1CsfpYGSMLAHMjxC 3asUdiQEAqEP98KKuoy8yK+HFmBauISaMYhIoWxmxKgUeFtXO1SUDPREOZHHkDFjQx93PucPHL ORc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jan 26, 2021 at 05:47:49PM +0100, Manuel Bouyer wrote:
> On Fri, Jan 15, 2021 at 04:27:12PM +0100, Roger Pau Monné wrote:
> > On Tue, Jan 12, 2021 at 07:12:24PM +0100, Manuel Bouyer wrote:
> > > From: Manuel Bouyer <bouyer@xxxxxxxxxx>
> > >
> > > When a domain is destroyed, xparams may not be available any more when
> > > the block script is called to unconfigure the vnd.
> > > Check xparam only at configure time, and just unconfigure any vnd present
> > > in the xenstore.
> >
> > The patch itself seems fine to me, there's no need to fetch params
> > for unplug, you can just reply on the vnd node.
> >
> > I'm however not sure why params would be deleted from xenstore but not
> > vnd, do you know why?
>
> I'm not sure, it happens on xl destroy, when the kernel in the
> domU is stuck (so it won't shutdown properly).
That's weird. Linux hotplug script will unconditionally read the
params node and we had no complaints there. Can you assert this still
happens with the latest version of Xen?
As said I think fetching vnd on detach is fine because there's no need
to fetch the other nodes, but this seems to be masking some kind of
error elsewhere.
Thanks, Roger.
|
