[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] x86/xen: avoid warning in Xen pv guest with CONFIG_AMD_MEM_ENCRYPT enabled
- To: Juergen Gross <jgross@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <x86@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 27 Jan 2021 09:43:31 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qD6hixH2FpJz5wfaTZ8Bu7e+a+vsNQyqtxNknJYYGR4=; b=Iad0HYRLYeiWsvkSVib5vwLQiUyptxN4zXVgeCV9BTmpP1SAHg0RhoL4GAx+XwD1VRdLhv0LQ4jBNFH4Z8mrgQU4dve3lPmv5/0gj77JMHFdQMokqIJXyr2tjvG32xyUkUSGQ6nE+UYvOND/STEJDRjSY0YHCfzzwjbPre5LWWX8/UEMUeA1j/OZfh6DKE3N7O7K/WxNbdZjVE/dnm4qZGzUX9RGO6lAzDniMVtuKRBVBW0cR2lN32pOY4i3O0bIbn4iyHiiyfjdFcbcHXvodsCgToheP3wGVokjnnTEsgIF88ZbHox3NAMw42pyvklkCutxmqffZuf+OrngnM1mZQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mOgW7rR0m8pTvdWT3nENCtJZhQxMq8SGTlqYdzMR8q7i2g2kTEIuithtg68JS1NwK0g1PotZwB+fzVI07cHElbcrXj//rGusKcb+z4dQcN8H0sNxGloL+NCFPsxvR3fMQiP5tGNhLWqW80BAS/lj/WhzTvc+zbevL++nZbmr+cF4GeMtcwMvpRDB+KYnYGnmz3p6iY01J4smStM4GDTaeValWifv+NVQ69qsIr4m//574LZmDnIdnaWa/4TCQ5rBCaXbWaNX+4X39pKe1C/21qEtD3CFxoa/pj+/xoaqDU3NOeWEJ6tljSlEQc5/VKUPhNdwIm00JrVjN/QogPbESQ==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, "Boris Ostrovsky" <boris.ostrovsky@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, <stable@xxxxxxxxxxxxxxx>
- Delivery-date: Wed, 27 Jan 2021 09:43:52 +0000
- Ironport-sdr: PLTFgBR7BKCv9kAbjEsBtI+57i/sVAjAvB7LnRlwEFZIowt4+5WEFXhaeSgBbKUR7hh2mitJr2 TrTnxYYkSyvhqo5DNRR1vNu1/vLcXj/R/jK31blewmqVB6KO1mpOZkuSLgzWwzQEtl4j8u2azr AAqL9jmBQBuqx+EnJC9MpSdQlHOa1G6yZh19i+JAta7TziJ5s+1VPME31p+al8Z8vVF+AnwyIn jvb0fj74/xDjn8y8YpfoDucw18pFo3AmYRe+Ey41YtjTLoQmxDK8cqYYYoYeGfSgBa9vHFigOs Uko=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27/01/2021 09:38, Juergen Gross wrote:
> diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
> index 4409306364dc..ca5ac10fcbf7 100644
> --- a/arch/x86/xen/enlighten_pv.c
> +++ b/arch/x86/xen/enlighten_pv.c
> @@ -583,6 +583,12 @@ DEFINE_IDTENTRY_RAW(xenpv_exc_debug)
> exc_debug(regs);
> }
>
> +DEFINE_IDTENTRY_RAW(exc_xen_unknown_trap)
> +{
> + /* This should never happen and there is no way to handle it. */
> + panic("Unknown trap in Xen PV mode.");
Looks much better. How about including regs->entry_vector here, just to
short circuit the inevitable swearing which will accompany encountering
this panic() ?
~Andrew
|
