[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] NetBSD hotplug: fix block unconfigure on destroy
- To: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 15 Jan 2021 16:27:12 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L4WKfqrlx0+OgYqe9BwWXs+XWfW/GpOxIemutZ4XtgI=; b=iYXO79W9TNPAI0W8yuwLdq/Hj2e9PmtkfTUb5HWgKdd/EuXguTbw6j2sTT5J2xnHhK1WSPX8rgOLkozzIwc5NKPh1yXADMQJGDaXM94O5y7DouiWhlyYIA8c4TLRpgUvQajGJGO8znOC5iK/m5pvSmoNsTmrP0jnZPHKjOza8E636IN4V9CNMY5iGR7jZ2XRo2vf7jQIsyRMnZC5+AYF4Cwg7De5TZmRlGUiQQZ21TSLbRdfHADcceHgc5B3cpTdC4Sn69AgEQHDQyt5jwngqVna1ab2+gPKzEq75qDCChfYRVu+iT9Sad/7DADUvFrcjov+X07MoPza6Prennbb/w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wv0GhWpKEqU+u1IiyjcsufCYHTIjMfYbl/nXA/0ldY5pfO+ySABQ28w0mgZjx/R8T9ah6pvJ0YOQ7qfThMqs0CsoNBiYWpoJipIzhU+uFfxVHcsZ0ih2CHhoMRD3fQplBCgoicdxQGf8cF3ky0nz4kfm//V/1EgjdYmHtQZAy9OCFV1VE92jiOqJEqpRfkV12n3ildtnjmJ+eoem8g+zDWdJvX6JNfAV5lYPQwuRW7r4ihP90gg4Q0PmjGy65G+S8qu0JXjuTIH7isGzUsZnW7olKJStSB3iV+BBP8uuKlcQDX9RcAwnBIpnEAXC5oCS+PhyAK9IdWzFOihVTTXByQ==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Manuel Bouyer <bouyer@xxxxxxxxxx>, "Ian Jackson" <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 15 Jan 2021 15:27:25 +0000
- Ironport-sdr: yLDFOSOqSCwea5vWZmc9Cs4VIeTa5cBpKEy50yG/bsUyb31B4O90WNHKgeTa11bhwY8Ae5/cwE pP4rGaFsrL008kxf14iTi8m1J4ZwKVvcclNFlmg7T72viO52cd/ku4ja5XeOtkkQt0IpxUH6ju lyJm8kusyDgWSy1gSRgNfmgrXtokSwttAaZc95cMDpDm9qZG4R9Y/n7lmfpxNrvljeH+Xyi3Bs fyB9V3k2HYvzIJd2KkwHfFbFl37DQrD1AkxdlTzWPUixnZQagNm5myv22TcaiU7BTC0gF7udGf e6U=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jan 12, 2021 at 07:12:24PM +0100, Manuel Bouyer wrote:
> From: Manuel Bouyer <bouyer@xxxxxxxxxx>
>
> When a domain is destroyed, xparams may not be available any more when
> the block script is called to unconfigure the vnd.
> Check xparam only at configure time, and just unconfigure any vnd present
> in the xenstore.
The patch itself seems fine to me, there's no need to fetch params
for unplug, you can just reply on the vnd node.
I'm however not sure why params would be deleted from xenstore but not
vnd, do you know why?
>
> Signed-off-by: Manuel Bouyer <bouyer@xxxxxxxxxx>
For the code itself:
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
