Re: [Xen-devel] [PATCH v2 2/5] IOMMU: iommu_intpost is x86/HVM-only

[Jan Beulich <jbeulich@xxxxxxxx>]

On 10.03.2020 13:20, Paul Durrant wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 10 March 2020 11:02
>> To: paul@xxxxxxx
>> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; 'Kevin Tian' <kevin.tian@xxxxxxxxx>; 
>> 'Stefano Stabellini'
>> <sstabellini@xxxxxxxxxx>; 'Julien Grall' <julien@xxxxxxx>; 'Wei Liu' 
>> <wl@xxxxxxx>; 'Konrad Wilk'
>> <konrad.wilk@xxxxxxxxxx>; 'George Dunlap' <George.Dunlap@xxxxxxxxxxxxx>; 
>> 'Andrew Cooper'
>> <andrew.cooper3@xxxxxxxxxx>; 'Ian Jackson' <ian.jackson@xxxxxxxxxx>
>> Subject: Re: [PATCH v2 2/5] IOMMU: iommu_intpost is x86/HVM-only
>>
>> On 10.03.2020 11:54, Paul Durrant wrote:
>>>> -----Original Message-----
>>>> From: Jan Beulich <jbeulich@xxxxxxxx>
>>>> Sent: 09 March 2020 10:43
>>>>
>>>> @@ -486,8 +480,10 @@ int __init iommu_setup(void)
>>>>          panic("Couldn't enable %s and iommu=required/force\n",
>>>>                !iommu_enabled ? "IOMMU" : "Interrupt Remapping");
>>>>
>>>> +#ifndef iommu_intpost
>>>>      if ( !iommu_intremap )
>>>>          iommu_intpost = 0;
>>>
>>> Nit: 0 -> false
>>
>> Hmm, I'm not touching this line, and the goal of the patch isn't
>> to (also) switch _all_ assignments to the variable.
> 
> Yes, but it is in context and you normally ask for fix-ups where
> they are in context. In this case it’s a pretty trivial addition to the patch.

Hmm, I now notice that in another place I already do such an in-context
adjustment, so I'll do so here too. Normally I (try to) restrict such
(requests) to lines touched anyway.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel