[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 2/5] IOMMU: iommu_intpost is x86/HVM-only

On 10.03.2020 11:54, Paul Durrant wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 09 March 2020 10:43
>> @@ -486,8 +480,10 @@ int __init iommu_setup(void)
>>          panic("Couldn't enable %s and iommu=required/force\n",
>>                !iommu_enabled ? "IOMMU" : "Interrupt Remapping");
>> +#ifndef iommu_intpost
>>      if ( !iommu_intremap )
>>          iommu_intpost = 0;
> Nit: 0 -> false

Hmm, I'm not touching this line, and the goal of the patch isn't
to (also) switch _all_ assignments to the variable. There is at
least one more (in vmcs.c), and doing the adjustment here (as
being not otherwise motivated, e.g. because of touching the line
anyway) would then, for consistency, seem to call for correcting
that other instance too. This, however, would seem too unrelated
a change to make here for my taste. Hence ...

> With that fixed...
> Reviewed-by: Paul Durrant <paul@xxxxxxx>

... please clarify whether I may leave the line untouched.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.