[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v1] x86/altp2m: Add hypercall to create a new view and set sve bits



Hi,

On 02/09/2019 09:11, Alexandru Stefan ISAILA wrote:
> By default the sve bits are not set.

While altp2m is currently only supported for x86 (though I am aware of 
some port for Arm), this patch extends an interface that is meant to be 
arch-agnostic. So what does "sve" stands for?

> diff --git a/xen/include/public/hvm/hvm_op.h b/xen/include/public/hvm/hvm_op.h
> index c6cd12f596..924d947e78 100644
> --- a/xen/include/public/hvm/hvm_op.h
> +++ b/xen/include/public/hvm/hvm_op.h
> @@ -244,6 +244,7 @@ struct xen_hvm_altp2m_view {
>       /* Create view only: default access type
>        * NOTE: currently ignored */
>       uint16_t hvmmem_default_access; /* xenmem_access_t */
> +    uint8_t set_sve; /* bool value */

Do we expect more "default" to be override? It might be worth 
considering to introduce flags rather than waste 8-bits per new default 
that can be encoded in 1-bit.

Cheers

-- 
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.