Xen project Mailing List

[Xen-devel] [PATCH v1] x86/altp2m: Add hypercall to create a new view and set sve bits

To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>

From: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>

Date: Mon, 2 Sep 2019 08:11:33 +0000

Accept-language: en-US

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gRGQXjvojTLYc64MbNu5kMSglQlYC1bw44CAr/waOIs=; b=F6EBIKlJ1cjBqKcuopv15VibXASODFb8JDdcnyXgXkGaubusIVVJ9BtD8ss1AqpKHA1HZEuzFCW7nuELA1Ew9fio4INIW10bBd7UrQA/RZYDQnA5h8K0v/EWJjhKhkKjEYrtzflO8HAQ/jod6O0y+WyMRGhDdVA2zp31+2L4z8vR3rAMcD7LSTwwQ9s3Dy5qOKkj5j+OvOxaqTBSO+3V2T2cdSbrH3w0DCI/fAsigNyFu4e0yRSMfU0i6RxuDAJ+Yk/o4/hTD7XJLzNgEjovbFxYJm5erxGVDKEl5xfq4FfonT3ehugSadwtKHpv+voZRz2g5MvsxKRZPOPlnHDfcg==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=deMcXJ3rVpwUJ2j+Pzuzwi78H2qgVPoFafOPPEfBAyxH/4hMLaAXAqqChYgPg9w4DwLKua46QzKPZJfjZBES3n11B0oilpBcctPYqHv3a2mRx7FfJdu4BwvZsnLyJAuKCp2fzhLdVDHybR2tpXgxgkdQn2/HVwJk9eoGQoyroa31frgysaLO3pB4tiPeHtP6lr4uCRIJevs+62SmD8Sm2mdV8AtBqQN0o/tPm4yxyfNkBYicH32xCvTbrtScXIAOeaXpPQc4MAn3uRvggjVsPsu07d7b3GKmbFGMHSMWBWTnpq+p2lWXgwXnKyzP+UlttGvnl9CC2gA89Vcr50AFFQ==

Authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisaila@xxxxxxxxxxxxxxx;

Cc: "kevin.tian@xxxxxxxxx" <kevin.tian@xxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "jun.nakajima@xxxxxxxxx" <jun.nakajima@xxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "tim@xxxxxxx" <tim@xxxxxxx>, "julien.grall@xxxxxxx" <julien.grall@xxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>

Delivery-date: Mon, 02 Sep 2019 08:11:42 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Thread-index: AQHVYWYIdb/r2yKq9kGUPnrK2APIqg==

Thread-topic: [PATCH v1] x86/altp2m: Add hypercall to create a new view and set sve bits

By default the sve bits are not set. This patch adds the option of setting the sve bits upon creating a new altp2m view. Signed-off-by: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx> --- tools/libxc/include/xenctrl.h | 3 +++ tools/libxc/xc_altp2m.c | 28 ++++++++++++++++++++++++++++ xen/arch/x86/hvm/hvm.c | 3 ++- xen/arch/x86/mm/p2m-ept.c | 19 ++++++++++++++++++- xen/arch/x86/mm/p2m.c | 10 +++++----- xen/include/asm-x86/hvm/vmx/vmx.h | 2 +- xen/include/asm-x86/p2m.h | 2 +- xen/include/public/hvm/hvm_op.h | 1 + 8 files changed, 59 insertions(+), 9 deletions(-) diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h index 0ff6ed9e70..86702e5df8 100644 --- a/tools/libxc/include/xenctrl.h +++ b/tools/libxc/include/xenctrl.h @@ -1925,6 +1925,9 @@ int xc_altp2m_set_vcpu_disable_notify(xc_interface *handle, uint32_t domid, uint32_t vcpuid); int xc_altp2m_create_view(xc_interface *handle, uint32_t domid, xenmem_access_t default_access, uint16_t *view_id); +int xc_altp2m_create_view_set_sve(xc_interface *handle, uint32_t domid, + xenmem_access_t default_access, + uint16_t *view_id, bool set_sve); int xc_altp2m_destroy_view(xc_interface *handle, uint32_t domid, uint16_t view_id); /* Switch all vCPUs of the domain to the specified altp2m view */ diff --git a/tools/libxc/xc_altp2m.c b/tools/libxc/xc_altp2m.c index a86520c232..aeb9f36ea0 100644 --- a/tools/libxc/xc_altp2m.c +++ b/tools/libxc/xc_altp2m.c @@ -139,6 +139,34 @@ int xc_altp2m_create_view(xc_interface *handle, uint32_t domid, return rc; } +int xc_altp2m_create_view_set_sve(xc_interface *handle, uint32_t domid, + xenmem_access_t default_access, + uint16_t *view_id, bool set_sve) +{ + int rc; + DECLARE_HYPERCALL_BUFFER(xen_hvm_altp2m_op_t, arg); + + arg = xc_hypercall_buffer_alloc(handle, arg, sizeof(*arg)); + if ( arg == NULL ) + return -1; + + arg->version = HVMOP_ALTP2M_INTERFACE_VERSION; + arg->cmd = HVMOP_altp2m_create_p2m; + arg->domain = domid; + arg->u.view.view = -1; + arg->u.view.hvmmem_default_access = default_access; + arg->u.view.set_sve = set_sve; + + rc = xencall2(handle->xcall, __HYPERVISOR_hvm_op, HVMOP_altp2m, + HYPERCALL_BUFFER_AS_ARG(arg)); + + if ( !rc ) + *view_id = arg->u.view.view; + + xc_hypercall_buffer_free(handle, arg); + return rc; +} + int xc_altp2m_destroy_view(xc_interface *handle, uint32_t domid, uint16_t view_id) { diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 029eea3b85..95d382b114 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -4627,7 +4627,8 @@ static int do_altp2m_op( } case HVMOP_altp2m_create_p2m: - if ( !(rc = p2m_init_next_altp2m(d, &a.u.view.view)) ) + if ( !(rc = p2m_init_next_altp2m(d, &a.u.view.view, + a.u.view.set_sve)) ) rc = __copy_to_guest(arg, &a, 1) ? -EFAULT : 0; break; diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index 6b8468c793..255ed97734 100644 --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -1339,7 +1339,7 @@ void setup_ept_dump(void) register_keyhandler('D', ept_dump_p2m_table, "dump VT-x EPT tables", 0); } -void p2m_init_altp2m_ept(struct domain *d, unsigned int i) +void p2m_init_altp2m_ept(struct domain *d, unsigned int i, bool set_sve) { struct p2m_domain *p2m = d->arch.altp2m_p2m[i]; struct p2m_domain *hostp2m = p2m_get_hostp2m(d); @@ -1355,6 +1355,23 @@ void p2m_init_altp2m_ept(struct domain *d, unsigned int i) ept = &p2m->ept; ept->mfn = pagetable_get_pfn(p2m_get_pagetable(p2m)); d->arch.altp2m_eptp[i] = ept->eptp; + + if ( set_sve ) + { + unsigned long gfn = 0, max_gpfn = domain_get_maximum_gpfn(d); + + for( ; gfn < max_gpfn; ++gfn ) + { + mfn_t mfn; + p2m_access_t a; + p2m_type_t t; + + altp2m_get_effective_entry(p2m, _gfn(gfn), &mfn, &t, &a, + AP2MGET_query); + p2m->set_entry(p2m, _gfn(gfn), mfn, PAGE_ORDER_4K, t, a, true); + + } + } } unsigned int p2m_find_altp2m_by_eptp(struct domain *d, uint64_t eptp) diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index 8a5229ee21..4ec61740f6 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -2528,7 +2528,7 @@ void p2m_flush_altp2m(struct domain *d) altp2m_list_unlock(d); } -static int p2m_activate_altp2m(struct domain *d, unsigned int idx) +static int p2m_activate_altp2m(struct domain *d, unsigned int idx, bool set_sve) { struct p2m_domain *hostp2m, *p2m; int rc; @@ -2554,7 +2554,7 @@ static int p2m_activate_altp2m(struct domain *d, unsigned int idx) goto out; } - p2m_init_altp2m_ept(d, idx); + p2m_init_altp2m_ept(d, idx, set_sve); out: p2m_unlock(p2m); @@ -2572,13 +2572,13 @@ int p2m_init_altp2m_by_id(struct domain *d, unsigned int idx) altp2m_list_lock(d); if ( d->arch.altp2m_eptp[idx] == mfn_x(INVALID_MFN) ) - rc = p2m_activate_altp2m(d, idx); + rc = p2m_activate_altp2m(d, idx, false); altp2m_list_unlock(d); return rc; } -int p2m_init_next_altp2m(struct domain *d, uint16_t *idx) +int p2m_init_next_altp2m(struct domain *d, uint16_t *idx, bool set_sve) { int rc = -EINVAL; unsigned int i; @@ -2590,7 +2590,7 @@ int p2m_init_next_altp2m(struct domain *d, uint16_t *idx) if ( d->arch.altp2m_eptp[i] != mfn_x(INVALID_MFN) ) continue; - rc = p2m_activate_altp2m(d, i); + rc = p2m_activate_altp2m(d, i, set_sve); if ( !rc ) *idx = i; diff --git a/xen/include/asm-x86/hvm/vmx/vmx.h b/xen/include/asm-x86/hvm/vmx/vmx.h index ebaa74449b..7707f1768f 100644 --- a/xen/include/asm-x86/hvm/vmx/vmx.h +++ b/xen/include/asm-x86/hvm/vmx/vmx.h @@ -598,7 +598,7 @@ void ept_p2m_uninit(struct p2m_domain *p2m); void ept_walk_table(struct domain *d, unsigned long gfn); bool_t ept_handle_misconfig(uint64_t gpa); void setup_ept_dump(void); -void p2m_init_altp2m_ept(struct domain *d, unsigned int i); +void p2m_init_altp2m_ept(struct domain *d, unsigned int i, bool set_sve); /* Locate an alternate p2m by its EPTP */ unsigned int p2m_find_altp2m_by_eptp(struct domain *d, uint64_t eptp); diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h index 94285db1b4..c85c91819e 100644 --- a/xen/include/asm-x86/p2m.h +++ b/xen/include/asm-x86/p2m.h @@ -884,7 +884,7 @@ bool p2m_altp2m_get_or_propagate(struct p2m_domain *ap2m, unsigned long gfn_l, int p2m_init_altp2m_by_id(struct domain *d, unsigned int idx); /* Find an available alternate p2m and make it valid */ -int p2m_init_next_altp2m(struct domain *d, uint16_t *idx); +int p2m_init_next_altp2m(struct domain *d, uint16_t *idx, bool set_sve); /* Make a specific alternate p2m invalid */ int p2m_destroy_altp2m_by_id(struct domain *d, unsigned int idx); diff --git a/xen/include/public/hvm/hvm_op.h b/xen/include/public/hvm/hvm_op.h index c6cd12f596..924d947e78 100644 --- a/xen/include/public/hvm/hvm_op.h +++ b/xen/include/public/hvm/hvm_op.h @@ -244,6 +244,7 @@ struct xen_hvm_altp2m_view { /* Create view only: default access type * NOTE: currently ignored */ uint16_t hvmmem_default_access; /* xenmem_access_t */ + uint8_t set_sve; /* bool value */ }; typedef struct xen_hvm_altp2m_view xen_hvm_altp2m_view_t; DEFINE_XEN_GUEST_HANDLE(xen_hvm_altp2m_view_t); -- 2.17.1 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.