Re: [Xen-devel] [PATCH 18/27] xen/arm: page: Prefix memory types with MT_

[Julien Grall <julien.grall@xxxxxxx>]

On 08/23/2017 12:41 PM, Andre Przywara wrote:
> Hi,
Hi Andre,

> On 14/08/17 15:24, Julien Grall wrote: >> diff --git 
> a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h
> > index 660e1779c5..d7a048b64d 100644
> > --- a/xen/include/asm-arm/page.h
> > +++ b/xen/include/asm-arm/page.h
> > @@ -25,17 +25,17 @@
> >    * LPAE Memory region attributes. Indexed by the AttrIndex bits of a
> >    * LPAE entry; the 8-bit fields are packed little-endian into MAIR0 and MAIR1.
> >    *
> > - *                 ai    encoding
> > - *   UNCACHED      000   0000 0000  -- Strongly Ordered
> > - *   BUFFERABLE    001   0100 0100  -- Non-Cacheable
> > - *   WRITETHROUGH  010   1010 1010  -- Write-through
> > - *   WRITEBACK     011   1110 1110  -- Write-back
> > - *   DEV_SHARED    100   0000 0100  -- Device
> > - *   ??            101
> > - *   reserved      110
> > - *   WRITEALLOC    111   1111 1111  -- Write-back write-allocate
> > + *                    ai    encoding
> > + *   MT_UNCACHED      000   0000 0000  -- Strongly Ordered
> > + *   MT_BUFFERABLE    001   0100 0100  -- Non-Cacheable
> > + *   MT_WRITETHROUGH  010   1010 1010  -- Write-through
> > + *   MT_WRITEBACK     011   1110 1110  -- Write-back
> > + *   MT_DEV_SHARED    100   0000 0100  -- Device
> > + *   ??               101
> > + *   reserved         110
> > + *   MT_WRITEALLOC    111   1111 1111  -- Write-back write-allocate
> >    *
> > - *   DEV_WC        001   (== BUFFERABLE)
> > + *   MT_DEV_WC        001   (== BUFFERABLE)
> It's just a comment, but for consistency this should be MT_BUFFERABLE
> here as well, I guess.
>
> Apart from that nit the rest looks correct.
Hmm, I dropped DEV_WC in patch #17 but forgot to remove it from the 
comment. I will drop it in that patch and ...
> Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>
... keep you reviewed-by here and the #17 if you are happy with it.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel