Re: [Xen-devel] [PATCH 19/27] xen/arm: page: Clean-up the definition of MAIRVAL

[Julien Grall <julien.grall@xxxxxxx>]

On 08/23/2017 12:42 PM, Andre Przywara wrote:
> Hi,
Hi Andre,

> On 14/08/17 15:24, Julien Grall wrote:
> > Currently MAIRVAL is defined in term of MAIR0VAL and MAIR1VAL which are
> > both hardcoded value. This makes quite difficult to understand the value
> > written in both registers.
> >
> > Rework the definition by using value of each attribute shifted by their
> > associated index.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> I checked all the bits and encoding against the ARMv8 ARM, they look
> correct to me.
> However I feel that the attribute renaming patch (20/27) should come
> before this one.
I can invert the two patches. I don't plan to keep your tags in both 
patches as this would sensibly change some bits.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel