Re: [Xen-devel] [PATCH v5] xen/arm64: check XSM Magic from the second unknown module.

[Fu Wei <fu.wei@xxxxxxxxxx>]

Hi Julien,

On 8 April 2016 at 22:51, Julien Grall <julien.grall@xxxxxxx> wrote:
> Hi Fu Wei,
>
> On 05/04/16 17:46, fu.wei@xxxxxxxxxx wrote:
>>
>> From: Fu Wei <fu.wei@xxxxxxxxxx>
>>
>> This patch adds a has_xsm_magic helper function for detecting XSM
>> from the second unknown module.
>>
>> If Xen can't get the kind of module from compatible, we guess the kind of
>> these unknowns respectively:
>>      (1) The first unknown must be kernel.
>>      (2) Detect the XSM Magic from the 2nd unknown:
>>          a. If it's XSM, set the kind as XSM, and that also means we
>>         won't load ramdisk;
>>         b. if it's not XSM, set the kind as ramdisk.
>>         So if user want to load ramdisk, it must be the 2nd unknown.
>
>
> The documentation in docs/misc/arm/device-tree/booting.txt needs to be
> update.

Yes, I may forgot this part, but I will make a new doc patch.
Thanks for reminding me

>
> Otherwise, the rest of the patch looks good to me.

Great thanks for your help

>
> Regards,
>
> --
> Julien Grall



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel