Xen project Mailing List

Re: [Xen-devel] [PATCH] arm/monitor vm-events: Implement guest-request support

To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>

From: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>

Date: Fri, 19 Feb 2016 18:35:20 +0200

Cc: Keir Fraser <keir@xxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>

Comment: DomainKeys? See http://domainkeys.sourceforge.net/

Delivery-date: Fri, 19 Feb 2016 16:35:36 +0000

Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=l096l09fS1KADkqqHVoKkyjvd2ntuy67yx3kVYvGMirkhFe7/hwr3tGcgl2jukmcOHZz+7R+rSJtLlhdGOzM/jcG5FdMdkcp0a45yZire8AJMH3A/he6r0TmzzHHWPXDqsw0CtibIctl7PXn0c2Om62iqwYoocU5B+NS5SSWdbU+bd2VfIkUcv1j/m4aTGvczHPfJOBmF6F0ppks16BVXduR3RvPKISVpqM+6M//AXx+/fE9bFRTez9DssUMtxb4kzxjL7kBoRvY7dnlzmUQv3xcsLjzr1vO2jTQP1/3910rtYgNZHOxa267cIYxZB8PwUyTmTns+nFTL1FMAHCYJg==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;

List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 2/19/2016 6:02 PM, Tamas K Lengyel wrote:

On Fri, Feb 19, 2016 at 7:26 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 18.02.16 at 20:35, <czuzu@xxxxxxxxxxxxxxx> wrote:
> ---
>Â MAINTAINERSÂ Â Â Â Â Â Â Â Â Â Â|Â Â1 +
>Â xen/arch/arm/hvm.cÂ Â Â Â Â Â Â |Â Â8 +++
>Â xen/arch/x86/hvm/event.cÂ Â Â Â | 116 ++++++----------------------------------
>Â xen/arch/x86/hvm/hvm.cÂ Â Â Â Â |Â Â1 +
>Â xen/arch/x86/monitor.cÂ Â Â Â Â |Â 14 -----
>Â xen/arch/x86/vm_event.cÂ Â Â Â Â|Â Â1 +
>Â xen/common/MakefileÂ Â Â Â Â Â Â|Â Â2 +-
>Â xen/common/hvm/MakefileÂ Â Â Â Â|Â Â3 +-
>Â xen/common/hvm/event.cÂ Â Â Â Â |Â 96 +++++++++++++++++++++++++++++++++

So here you _again_ try to introduce something HVM-ish for ARM.
Why? Why can't this code live in common/vm_event.c?

I too am wondering if this is the right way to architect this. It would be better to move the guest-requested stuff into the generic vm_event component as it doesn't seem to be HVM specific other then it using an HVMOP hypercall to be triggered.

Tamas

Oh, that. "xen/common/hvm/event.c". I too don't know if it's the right way, but Jan, please at least don't attribute the way the code already is to me, I did not architect it.
And it's not human to expect doing everything perfectly in a single shot. If you're of the opinion that it should be in vm_event.c I will gladly try to put it there. Of course, that
could also be done in another patch.

Corneliu.

_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel