Re: [Xen-devel] [PATCH] arm/monitor vm-events: Implement guest-request support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.02.16 at 20:35, <czuzu@xxxxxxxxxxxxxxx> wrote:
> ---
>  MAINTAINERS                     |   1 +
>  xen/arch/arm/hvm.c              |   8 +++
>  xen/arch/x86/hvm/event.c        | 116 
> ++++++----------------------------------
>  xen/arch/x86/hvm/hvm.c          |   1 +
>  xen/arch/x86/monitor.c          |  14 -----
>  xen/arch/x86/vm_event.c         |   1 +
>  xen/common/Makefile             |   2 +-
>  xen/common/hvm/Makefile         |   3 +-
>  xen/common/hvm/event.c          |  96 +++++++++++++++++++++++++++++++++

So here you _again_ try to introduce something HVM-ish for ARM.
Why? Why can't this code live in common/vm_event.c?

> --- a/xen/include/asm-x86/domain.h
> +++ b/xen/include/asm-x86/domain.h
> @@ -376,17 +376,15 @@ struct arch_domain
>      unsigned long *pirq_eoi_map;
>      unsigned long pirq_eoi_map_mfn;
>  
> -    /* Monitor options */
> +    /* Arch-specific monitor options */
>      struct {
> -        unsigned int write_ctrlreg_enabled       : 4;
> -        unsigned int write_ctrlreg_sync          : 4;
> -        unsigned int write_ctrlreg_onchangeonly  : 4;
> -        unsigned int mov_to_msr_enabled          : 1;
> -        unsigned int mov_to_msr_extended         : 1;
> -        unsigned int singlestep_enabled          : 1;
> -        unsigned int software_breakpoint_enabled : 1;
> -        unsigned int guest_request_enabled       : 1;
> -        unsigned int guest_request_sync          : 1;
> +        uint16_t write_ctrlreg_enabled       : 4;
> +        uint16_t write_ctrlreg_sync          : 4;
> +        uint16_t write_ctrlreg_onchangeonly  : 4;
> +        uint16_t mov_to_msr_enabled          : 1;
> +        uint16_t mov_to_msr_extended         : 1;
> +        uint16_t singlestep_enabled          : 1;
> +        uint16_t software_breakpoint_enabled : 1;
>      } monitor;

What is this type change supposed to achieve in general, and in
particular in the context of this patch?

> --- a/xen/include/asm-x86/hvm/event.h
> +++ b/xen/include/asm-x86/hvm/event.h
> @@ -1,5 +1,9 @@
>  /*
> - * event.h: Hardware virtual machine assist events.
> + * include/asm-x86/hvm/event.h
> + *
> + * Arch-specific hardware virtual machine event abstractions.
> + *
> + * Copyright (c) 2016, Bitdefender S.R.L.

Is this true? Namely, was _all_ of the code here written by people
on your company, including what may have got moved here from
elsewhere?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel