Xen project Mailing List

Re: [Xen-devel] [PATCH] arm/monitor vm-events: Implement guest-request support

From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>

Date: Fri, 19 Feb 2016 09:02:59 -0700

Cc: Keir Fraser <keir@xxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>

Delivery-date: Fri, 19 Feb 2016 16:03:05 +0000

List-id: Xen developer discussion <xen-devel.lists.xen.org>

On Fri, Feb 19, 2016 at 7:26 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 18.02.16 at 20:35, <czuzu@xxxxxxxxxxxxxxx> wrote:
> ---
>Â MAINTAINERSÂ Â Â Â Â Â Â Â Â Â Â|Â Â1 +
>Â xen/arch/arm/hvm.cÂ Â Â Â Â Â Â |Â Â8 +++
>Â xen/arch/x86/hvm/event.cÂ Â Â Â | 116 ++++++----------------------------------
>Â xen/arch/x86/hvm/hvm.cÂ Â Â Â Â |Â Â1 +
>Â xen/arch/x86/monitor.cÂ Â Â Â Â |Â 14 -----
>Â xen/arch/x86/vm_event.cÂ Â Â Â Â|Â Â1 +
>Â xen/common/MakefileÂ Â Â Â Â Â Â|Â Â2 +-
>Â xen/common/hvm/MakefileÂ Â Â Â Â|Â Â3 +-
>Â xen/common/hvm/event.cÂ Â Â Â Â |Â 96 +++++++++++++++++++++++++++++++++

So here you _again_ try to introduce something HVM-ish for ARM.
Why? Why can't this code live in common/vm_event.c?

I too am wondering if this is the right way to architect this. It would be better to move the guest-requested stuff into the generic vm_event component as it doesn't seem to be HVM specific other then it using an HVMOP hypercall to be triggered.

Tamas

_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel