Re: [Xen-devel] [PATCH v3 03/23] xen-xsplice: Tool to manipulate xsplice payloads (v4)

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Feb 12, 2016 at 01:05:41PM -0500, Konrad Rzeszutek Wilk wrote:
[...]
> diff --git a/tools/misc/xen-xsplice.c b/tools/misc/xen-xsplice.c
> new file mode 100644
> index 0000000..13f762f
> --- /dev/null
> +++ b/tools/misc/xen-xsplice.c

One gripe I have with this program is that many of its functions mix
direct return and goto style error handling.

> @@ -0,0 +1,470 @@
> +/*
> + * Copyright (c) 2016 Oracle and/or its affiliates. All rights reserved.
> + */
> +
[...]
> +static const char *state2str(long state)
> +{
> +#define STATE(x) [XSPLICE_STATE_##x] = #x
> +    static const char *const names[] = {
> +            STATE(LOADED),
> +            STATE(CHECKED),
> +            STATE(APPLIED),
> +    };
> +#undef STATE
> +    if (state >= ARRAY_SIZE(names))
> +        return "unknown";
> +
> +    if (state < 0)
> +        return "-EXX";
> +

This doesn't look very useful.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel