Re: [Xen-devel] [PATCH] x86emul: MSR indexes are only 32 bits wide

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.02.16 at 13:51, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 15/02/16 11:57, Jan Beulich wrote:
>> ... and hence the respective {read,write}_msr() hook parameter doesn't
>> need to be "unsigned long".
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> I would suggest uint32_t instead (being more architecturally
> self-documenting), but either way, Reviewed-by: Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>

While it might be "more architecturally self-documenting", it would
also be less in line with types used elsewhere (at least for those
pieces which I had looked at). This consistency consideration made
me use unsigned int (which we imply to be at least 32 bits wide
anyway).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel