[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH V6 4/5] xen/mm: Clean up pfec handling in gva_to_gfn
On Wed, 2016-01-27 at 09:34 +0000, Tim Deegan wrote: > Hi, > > At 07:22 +0000 on 27 Jan (1453879344), Han, Huaitong wrote: > > On Tue, 2016-01-26 at 14:30 +0000, Tim Deegan wrote: > > > This seems OK. But can you please: > > > - Add this new adjustment once, in paging_gva_to_gfn(), instead > > > of > > > adding it to each implementation; and > > > - Adjust the comment above the declaration of > > > paging_gva_to_gfn() in > > > paging.h to describe this new behaviour. > > Although adding adjustment in paging_gva_to_gfn can reduce code > > duplication, adding it to each implementation is more readable, > > becasue > > other sections of pfec are handled in each implementation. > > True, but since paging_gva_to_gfn() is already non-trivial and this > is a different kind of adjustment, I'd still like it done there. > I'll leave this to George's discretion as x86/mm maintainer. > > But in any case, please add the comment describing the new semantics. To George: What is your opinion on Tim's comment? To Tim: I will update the codes and the comment in patch serial V8. > Cheers, > > Tim. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |