[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [v3][PATCH 03/16] xen/vtd: create RMRR mapping



On 2015/6/17 18:03, Jan Beulich wrote:
On 11.06.15 at 03:15, <tiejun.chen@xxxxxxxxx> wrote:
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -927,10 +927,16 @@ int set_identity_p2m_entry(struct domain *d, unsigned 
long gfn,
          }

          gfn_unlock(p2m, gfn, 0);
-        return ret;
      }
+    else
+        ret = 0;

-    return 0;
+    if( ret == 0 )
+    {
+        ret = iommu_map_page(d, gfn, gfn, IOMMUF_readable|IOMMUF_writable);
+    }

Pointless braces and missing blank in the if() statement. I also think
this should be added right when the function gets introduced.

Finally I think we should remove this change since p2m_set_entry() always set iommu page map internally.

Thanks
Tiejun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.