Re: [Xen-devel] [PATCH v2 05/17] x86/hvm: unify stdvga mmio intercept with standard mmio intercept

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.06.15 at 18:30, <Paul.Durrant@xxxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: 17 June 2015 16:51
>> >>> On 11.06.15 at 17:42, <paul.durrant@xxxxxxxxxx> wrote:
>> > --- a/xen/arch/x86/hvm/emulate.c
>> > +++ b/xen/arch/x86/hvm/emulate.c
>> > @@ -273,6 +273,15 @@ static int hvmemul_acquire_page(unsigned long
>> gmfn, struct page_info **page)
>> >          return X86EMUL_RETRY;
>> >      }
>> >
>> > +    /* This code should not be reached if the gmfn is not RAM */
>> > +    if ( p2m_is_mmio(p2mt) )
>> > +    {
>> > +        domain_crash(d);
>> 
>> Log a message at least? Silent domain death is rather ugly to analyze.
> 
> You do get a file+line (since domain_crash is actually a macro with a printk 
> in it too) but I can also log something.

Ah, right, I forgot about that. No extra message necessary then
I guess.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel