Re: [Xen-devel] [v3][PATCH 03/16] xen/vtd: create RMRR mapping

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.06.15 at 03:15, <tiejun.chen@xxxxxxxxx> wrote:
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -927,10 +927,16 @@ int set_identity_p2m_entry(struct domain *d, unsigned 
> long gfn,
>          }
>  
>          gfn_unlock(p2m, gfn, 0);
> -        return ret;
>      }
> +    else
> +        ret = 0;
>  
> -    return 0;
> +    if( ret == 0 )
> +    {
> +        ret = iommu_map_page(d, gfn, gfn, IOMMUF_readable|IOMMUF_writable);
> +    }

Pointless braces and missing blank in the if() statement. I also think
this should be added right when the function gets introduced.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel