Re: [Xen-devel] [PATCH v6 1/8] xenalyze: add to tools/xentrace/

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-06-11 at 16:30 +0000, Olaf Hering wrote:
> @@ -26,6 +28,7 @@ install: build
>       [ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
>       $(INSTALL_DIR) $(DESTDIR)$(MAN1DIR)
>       $(INSTALL_DIR) $(DESTDIR)$(MAN8DIR)
> +     $(INSTALL_PROG) $(BIN) $(DESTDIR)$(bindir)

Building on !x86 fails here because $(BIN) is empty:
install: missing destination file operand after 
`/local/scratch/ianc/devel/committer-arm32.git/dist/install/usr/local/bin'
Try `install --help' for more information.

I propose to continue trying to commit with this fixup patch folded in:

diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
index 8932b73..3676812 100644
--- a/tools/xentrace/Makefile
+++ b/tools/xentrace/Makefile
@@ -28,7 +28,9 @@ install: build
        [ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
        $(INSTALL_DIR) $(DESTDIR)$(MAN1DIR)
        $(INSTALL_DIR) $(DESTDIR)$(MAN8DIR)
+ifneq ($(BIN),)
        $(INSTALL_PROG) $(BIN) $(DESTDIR)$(bindir)
+endif
        $(INSTALL_PROG) $(SBIN) $(DESTDIR)$(sbindir)
        $(INSTALL_PYTHON_PROG) $(SCRIPTS) $(DESTDIR)$(bindir)
        [ -z "$(LIBBIN)" ] || $(INSTALL_PROG) $(LIBBIN) $(DESTDIR)$(LIBEXEC_BIN)




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel