Re: [Xen-devel] [OSSTEST PATCH 11/12] reporting: Show slightly better info for broken jobs

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-06-16 at 11:13 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [OSSTEST PATCH 11/12] reporting: Show slightly 
> better info for broken jobs"):
> > On Mon, 2015-06-15 at 18:13 +0100, Ian Jackson wrote:
> > > Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ...
> > > -    } elsif ($status eq 'fail') {
> > > +    } elsif ($status eq 'fail' or $status eq 'broken') {
> > > + my $failcolour = $status eq 'fail' ? $red : $yellow;
> > >   our $failstepq //= db_prepare(<<END);
> > >       SELECT * FROM steps
> > >        WHERE flight=? AND job=?
> > > @@ -217,10 +218,12 @@ END
> > >          if (!defined $fs) {
> > >              return { Summary => "(unknown)", Colour => $yellow };
> > >          } elsif ($fs->{status} eq 'fail') {
> > > -            return { Summary => "$fs->{testid}", Colour => $red };
> > > +            return { Summary => "$fs->{testid}", Colour => $failcolour };
> > > +        } elsif ($fs->{status} eq 'broken') {
> > > +            return { Summary => "$fs->{testid} broken", Colour => 
> > > $yellow };
> > 
> > Not $failcolour?
> 
> Using $failcolour instead of $yellow there would only make a
> difference if the job was `fail' but the step was `broken'.  So this
> is a bit of an edge case.
> 
> But I think in that situation $red is probably better, so I will
> change this.

OK. You can put my Ack on it if you like.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel