Re: [Xen-devel] [OSSTEST PATCH 11/12] reporting: Show slightly better info for broken jobs

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-06-15 at 18:13 +0100, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ---
>  Osstest/Executive.pm |    9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
> index 6edbfee..6c16fdd 100644
> --- a/Osstest/Executive.pm
> +++ b/Osstest/Executive.pm
> @@ -204,7 +204,8 @@ sub report_run_getinfo ($) {
>      my $status= $f->{status};
>      if ($status eq 'pass') {
>          return { Summary => "($status)", Colour => $green };
> -    } elsif ($status eq 'fail') {
> +    } elsif ($status eq 'fail' or $status eq 'broken') {
> +     my $failcolour = $status eq 'fail' ? $red : $yellow;
>       our $failstepq //= db_prepare(<<END);
>           SELECT * FROM steps
>            WHERE flight=? AND job=?
> @@ -217,10 +218,12 @@ END
>          if (!defined $fs) {
>              return { Summary => "(unknown)", Colour => $yellow };
>          } elsif ($fs->{status} eq 'fail') {
> -            return { Summary => "$fs->{testid}", Colour => $red };
> +            return { Summary => "$fs->{testid}", Colour => $failcolour };
> +        } elsif ($fs->{status} eq 'broken') {
> +            return { Summary => "$fs->{testid} broken", Colour => $yellow };

Not $failcolour?

(Or alternatively why is the fail case changing if not)

>          } else {
>              return { Summary => "$fs->{testid} $fs->{status}",
> -                     Colour => $red };
> +                     Colour => $failcolour };
>          }
>      } elsif ($status eq 'blocked') {
>          return { Summary => "blocked", Colour => $purple },



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel