Re: [Xen-devel] [PATCH v6 1/8] xenalyze: add to tools/xentrace/

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-06-16 at 11:24 +0100, Ian Campbell wrote:
> On Thu, 2015-06-11 at 16:30 +0000, Olaf Hering wrote:
> > @@ -26,6 +28,7 @@ install: build
> >     [ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> >     $(INSTALL_DIR) $(DESTDIR)$(MAN1DIR)
> >     $(INSTALL_DIR) $(DESTDIR)$(MAN8DIR)
> > +   $(INSTALL_PROG) $(BIN) $(DESTDIR)$(bindir)
> 
> Building on !x86 fails here because $(BIN) is empty:
> install: missing destination file operand after 
> `/local/scratch/ianc/devel/committer-arm32.git/dist/install/usr/local/bin'
> Try `install --help' for more information.
> 
> I propose to continue trying to commit with this fixup patch folded
> in:

This didn't succeed because $(BIN) at this point is actually ' ', not
''. Due to the BIN += $(BIN-y), which is approximately:
        BIN := '$(BIN) $(BIN-y)'

Since in the context it doesn't yet matter, I'll fold in this too:

@@ -6,9 +6,8 @@ CFLAGS += -Werror
 CFLAGS += $(CFLAGS_libxenctrl)
 LDLIBS += $(LDLIBS_libxenctrl)
 
-BIN      =
 BIN-$(CONFIG_X86) = xenalyze
-BIN     += $(BIN-y)
+BIN      = $(BIN-y)
 SBIN     = xentrace xentrace_setsize
 LIBBIN   = xenctx
 SCRIPTS  = xentrace_format




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel