[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v11 5/9] xen: Add vmware_port support
- To: Jan Beulich <JBeulich@xxxxxxxx>, Don Slutz <dslutz@xxxxxxxxxxx>
- From: Don Slutz <don.slutz@xxxxxxxxx>
- Date: Fri, 05 Jun 2015 09:18:28 -0400
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, xen-devel@xxxxxxxxxxxxx, Eddie Dong <eddie.dong@xxxxxxxxx>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
- Delivery-date: Fri, 05 Jun 2015 13:18:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 06/05/15 05:52, Jan Beulich wrote:
On 22.05.15 at 17:50, <dslutz@xxxxxxxxxxx> wrote:
@@ -5805,6 +5808,12 @@ static int hvmop_set_param(
break;
if ( a.value > 1 )
rc = -EINVAL;
+ /* Prevent nestedhvm with vmport */
+ if ( d->arch.hvm_domain.is_vmware_port_enabled )
+ {
+ rc = -EOPNOTSUPP;
+ break;
+ }
Surrounding code avoiding the use of "break" makes the result look
rather inconsistent. Please move this up immediately after the XSM
check, or drop the "break".
Will do.
-Don Slutz
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
