[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH] xen/sched_rc: Fix memory leak in rt_init()
Introduced by c/s 376bbba "sched_rt: print useful affinity info when dumping". If the allocation of cpumask failed, prv was leaked. Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Coverity-ID: 1304398 CC: Keir Fraser <keir@xxxxxxx> CC: Jan Beulich <JBeulich@xxxxxxxx> CC: Dario Faggioli <dario.faggioli@xxxxxxxxxx> CC: George Dunlap <george.dunlap@xxxxxxxxxxxxx> CC: Meng Xu <mengxu@xxxxxxxxxxxxx> --- xen/common/sched_rt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c index 5836d27..4372486 100644 --- a/xen/common/sched_rt.c +++ b/xen/common/sched_rt.c @@ -441,7 +441,7 @@ static inline struct list_head *rt_depletedq(const struct scheduler *ops) { _cpumask_scratch = xmalloc_array(cpumask_var_t, nr_cpu_ids); if ( !_cpumask_scratch ) - return -ENOMEM; + goto no_mem; } nr_rt_ops++; @@ -455,6 +455,10 @@ static inline struct list_head *rt_depletedq(const struct scheduler *ops) ops->sched_data = prv; return 0; + + no_mem: + xfree(prv); + return -ENOMEM; } static void -- 1.7.10.4 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |