Re: [Xen-devel] [PATCH v11 5/9] xen: Add vmware_port support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.05.15 at 17:50, <dslutz@xxxxxxxxxxx> wrote:
> @@ -5805,6 +5808,12 @@ static int hvmop_set_param(
>              break;
>          if ( a.value > 1 )
>              rc = -EINVAL;
> +        /* Prevent nestedhvm with vmport */
> +        if ( d->arch.hvm_domain.is_vmware_port_enabled )
> +        {
> +            rc = -EOPNOTSUPP;
> +            break;
> +        }

Surrounding code avoiding the use of "break" makes the result look
rather inconsistent. Please move this up immediately after the XSM
check, or drop the "break".

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel