[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()
- To: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx>
- From: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
- Date: Tue, 21 Apr 2015 14:12:31 -0700
- Cc: "linux-fbdev@xxxxxxxxxxxxxxx" <linux-fbdev@xxxxxxxxxxxxxxx>, "mst@xxxxxxxxxx" <mst@xxxxxxxxxx>, Daniel Vetter <daniel.vetter@xxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "Hefty, Sean" <sean.hefty@xxxxxxxxx>, "cocci@xxxxxxxxxxxxxxx" <cocci@xxxxxxxxxxxxxxx>, "ville.syrjala@xxxxxxxxxxxxxxx" <ville.syrjala@xxxxxxxxxxxxxxx>, "roland@xxxxxxxxxx" <roland@xxxxxxxxxx>, Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>, "linux-rdma@xxxxxxxxxxxxxxx" <linux-rdma@xxxxxxxxxxxxxxx>, Roland Dreier <roland@xxxxxxxxxxxxxxx>, Tomi Valkeinen <tomi.valkeinen@xxxxxx>, Suresh Siddha <sbsiddha@xxxxxxxxx>, Dave Airlie <airlied@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>, "hal.rosenstock@xxxxxxxxx" <hal.rosenstock@xxxxxxxxx>, Antonino Daplas <adaplas@xxxxxxxxx>, Stefan Bader <stefan.bader@xxxxxxxxxxxxx>, infinipath <infinipath@xxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Marciniszyn, Mike" <mike.marciniszyn@xxxxxxxxx>, Toshi Kani <toshi.kani@xxxxxx>, "Dalessandro, Dennis" <dennis.dalessandro@xxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "david.vrabel@xxxxxxxxxx" <david.vrabel@xxxxxxxxxx>, Roger Pau Monnà <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 21 Apr 2015 21:13:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Tue, Apr 21, 2015 at 2:09 PM, Luis R. Rodriguez
<mcgrof@xxxxxxxxxxxxxxxx> wrote:
> On Tue, Apr 21, 2015 at 1:59 PM, Marciniszyn, Mike
> <mike.marciniszyn@xxxxxxxxx> wrote:
>>> > This driver already makes use of ioremap_wc() on PIO buffers, so
>>> > convert it to use arch_phys_wc_add().
>>>
>>> This is probably OK, but I think you should also remove the qib_wc_pat
>>> module
>>> parameter.
>>>
>>> Jason
>>
>> Revise based on Jason's request and I will do some testing.
>
> I did thiink about this -- but removal of module parameters can often
> times break users of the module parameter, I figured its best to leave
> it to you guys to decide what to do with that, so this leaves it as a
> no-op. Can this series be applied and then you can decide what to do
> to not affect your users on top of this?
As of a few kernel versions ago, unrecognized module parameters no
longer cause the module to refuse to load.
--Andy
>
> Luis
--
Andy Lutomirski
AMA Capital Management, LLC
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
