[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()
- To: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx>
- From: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>
- Date: Tue, 21 Apr 2015 14:57:16 -0600
- Cc: linux-fbdev@xxxxxxxxxxxxxxx, mst@xxxxxxxxxx, Daniel Vetter <daniel.vetter@xxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, jbeulich@xxxxxxxx, sean.hefty@xxxxxxxxx, cocci@xxxxxxxxxxxxxxx, ville.syrjala@xxxxxxxxxxxxxxx, roland@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>, linux-rdma@xxxxxxxxxxxxxxx, Roland Dreier <roland@xxxxxxxxxxxxxxx>, Tomi Valkeinen <tomi.valkeinen@xxxxxx>, Suresh Siddha <sbsiddha@xxxxxxxxx>, Dave Airlie <airlied@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>, hal.rosenstock@xxxxxxxxx, Antonino Daplas <adaplas@xxxxxxxxx>, "Luis R. Rodriguez" <mcgrof@xxxxxxxx>, Stefan Bader <stefan.bader@xxxxxxxxxxxxx>, infinipath@xxxxxxxxx, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>, Toshi Kani <toshi.kani@xxxxxx>, Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, luto@xxxxxxxxxxxxxx, david.vrabel@xxxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 22 Apr 2015 05:44:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Tue, Apr 21, 2015 at 01:37:55PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
>
> This driver already makes use of ioremap_wc() on PIO buffers,
> so convert it to use arch_phys_wc_add().
This is probably OK, but I think you should also remove the qib_wc_pat
module parameter.
Jason
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|