[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()
- To: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>, "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx>
- From: "Marciniszyn, Mike" <mike.marciniszyn@xxxxxxxxx>
- Date: Tue, 21 Apr 2015 20:59:41 +0000
- Accept-language: en-US
- Cc: "linux-fbdev@xxxxxxxxxxxxxxx" <linux-fbdev@xxxxxxxxxxxxxxx>, "mst@xxxxxxxxxx" <mst@xxxxxxxxxx>, Daniel Vetter <daniel.vetter@xxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "Hefty, Sean" <sean.hefty@xxxxxxxxx>, "cocci@xxxxxxxxxxxxxxx" <cocci@xxxxxxxxxxxxxxx>, "ville.syrjala@xxxxxxxxxxxxxxx" <ville.syrjala@xxxxxxxxxxxxxxx>, "roland@xxxxxxxxxx" <roland@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>, "linux-rdma@xxxxxxxxxxxxxxx" <linux-rdma@xxxxxxxxxxxxxxx>, Roland Dreier <roland@xxxxxxxxxxxxxxx>, Tomi Valkeinen <tomi.valkeinen@xxxxxx>, Suresh Siddha <sbsiddha@xxxxxxxxx>, Dave Airlie <airlied@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>, "hal.rosenstock@xxxxxxxxx" <hal.rosenstock@xxxxxxxxx>, Antonino Daplas <adaplas@xxxxxxxxx>, "Luis R. Rodriguez" <mcgrof@xxxxxxxx>, Stefan Bader <stefan.bader@xxxxxxxxxxxxx>, infinipath <infinipath@xxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Toshi Kani <toshi.kani@xxxxxx>, "Dalessandro, Dennis" <dennis.dalessandro@xxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "luto@xxxxxxxxxxxxxx" <luto@xxxxxxxxxxxxxx>, "david.vrabel@xxxxxxxxxx" <david.vrabel@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 22 Apr 2015 05:44:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
- Thread-index: AQHQfHMZqO6KUFxC/UadMhLEgyOnQp1YZ/EA//+LJuA=
- Thread-topic: [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()
> > This driver already makes use of ioremap_wc() on PIO buffers, so
> > convert it to use arch_phys_wc_add().
>
> This is probably OK, but I think you should also remove the qib_wc_pat module
> parameter.
>
> Jason
Revise based on Jason's request and I will do some testing.
Mike
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|