Re: [Xen-devel] [PATCH 3/4] xen: sched: make counters for vCPU tickling generic

[Meng Xu <xumengpanda@xxxxxxxxx>]

2015-02-27 5:53 GMT-05:00 Dario Faggioli <dario.faggioli@xxxxxxxxxx>:
> On Fri, 2015-02-27 at 00:47 -0500, Meng Xu wrote:
>
>> 2015-02-26 8:37 GMT-05:00 Dario Faggioli <dario.faggioli@xxxxxxxxxx>:
>>         and update them from Credit2 and RTDS schedulers.
>>
>>         Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
>>         Cc: Meng Xu <xumengpanda@xxxxxxxxx>
>>         Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
>>         Cc: Jan Beulich <JBeulich@xxxxxxxx>
>>         Cc: Keir Fraser <keir@xxxxxxx>
>>         ---
>>          xen/common/sched_credit2.c   |    2 ++
>>          xen/common/sched_rt.c        |    2 ++
>>          xen/include/xen/perfc_defn.h |    4 ++--
>>          3 files changed, 6 insertions(+), 2 deletions(-)
>>
>> The change for RTDS scheduler looks good to me.
>>
> Does this count as a "Reviewed-by: Meng Xu <mengxu@xxxxxxxxxxxxx>" ?
>
> Also, if yes, does it also apply to patch #2 ? That is unclear as
> sched_rt.c is modified in patches #1, #2 ad #3, while what you did is:
>  - you explicitly provided the tag for patch #1
>  - you said "looks good" for this for patch #3
>  - you said nothing for patch #2
>
> The bottom line of all this being: with Ack-s/Reviewed-by-s, it's always
> better be pretty explicit! :-D

I see. Thank you very much, Dario, for explaining this to me! :-)

After you add return before no_tickle:, this patch is good to go, IMHO.

So after the this change,
Reviewed-by: Meng Xu <mengxu@xxxxxxxxxxxxx>

Thank you very much!

Best,

Meng



-- 


-----------
Meng Xu
PhD Student in Computer and Information Science
University of Pennsylvania

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel