Re: [Xen-devel] [PATCH 3/4] xen: sched: make counters for vCPU tickling generic

[Meng Xu <xumengpanda@xxxxxxxxx>]

2015-02-26 8:37 GMT-05:00 Dario Faggioli <dario.faggioli@xxxxxxxxxx>:

and update them from Credit2 and RTDS schedulers.

Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
Cc: Meng Xu <xumengpanda@xxxxxxxxx>
Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
Cc: Jan Beulich <JBeulich@xxxxxxxx>
Cc: Keir Fraser <keir@xxxxxxx>
---
Âxen/common/sched_credit2.c Â|  2 ++
Âxen/common/sched_rt.c    |  2 ++
Âxen/include/xen/perfc_defn.h |Â Â 4 ++--
Â3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
index 2b852cc..bf13a84 100644
--- a/xen/common/sched_credit2.c
+++ b/xen/common/sched_credit2.c
@@ -571,9 +571,11 @@ tickle:
         Â(unsigned char *)&d);
  Â}
  Âcpumask_set_cpu(ipid, &rqd->tickled);
+Â Â SCHED_STAT_CRANK(tickle_idlers_some);
  Âcpu_raise_softirq(ipid, SCHEDULE_SOFTIRQ);

Âno_tickle:
+Â Â SCHED_STAT_CRANK(tickle_idlers_none);
  Âreturn;
Â}

diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c
index 49d1b83..2ad0c68 100644
--- a/xen/common/sched_rt.c
+++ b/xen/common/sched_rt.c
@@ -929,6 +929,7 @@ runq_tickle(const struct scheduler *ops, struct rt_vcpu *new)
  Â}

  Â/* didn't tickle any cpu */
+Â Â SCHED_STAT_CRANK(tickle_idlers_none);
  Âreturn;
Âout:
  Â/* TRACE */
@@ -944,6 +945,7 @@ out:
  Â}

  Âcpumask_set_cpu(cpu_to_tickle, &prv->tickled);
+Â Â SCHED_STAT_CRANK(tickle_idlers_some);
  Âcpu_raise_softirq(cpu_to_tickle, SCHEDULE_SOFTIRQ);
  Âreturn;
Â}

âThe change for RTDS scheduler looks good to me.

Thanks,

Mengâ

--

-----------
Meng Xu
PhD Student in Computer and Information Science
University of Pennsylvania

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel