Re: [Xen-devel] [PATCH] tools/hotplug: update systemd dependency to use service instead of socket

[M A Young <m.a.young@xxxxxxxxxxxx>]

On Tue, 2 Dec 2014, Konrad Rzeszutek Wilk wrote:

> On Tue, Dec 02, 2014 at 03:44:55PM +0000, Ian Campbell wrote:
> > On Tue, 2014-12-02 at 16:39 +0100, Olaf Hering wrote:
> > > Since commit 4542ae340d75bd6319e3fcd94e6c9336e210aeef ("tools/hotplug:
> > > systemd xenstored dependencies") all service files use the .socket unit
> > > as startup dependency. While this happens to work for boot it fails for
> > > shutdown because a .socket does not seem to enforce ordering. When
> > > xendomains.service runs during shutdown then systemd will stop
> > > xenstored.service at the same time.
> > >
> > > Change all "xenstored.socket" to "xenstored.service" to let systemd know
> > > that xenstored has to be shutdown after everything else.
> > >
> > > Reported-by: Mark Pryor <tlviewer@xxxxxxxxx>
> > > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> > > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > ---
> > >
> > > This should go into 4.5 to fix xendomains.service.
> > CCing Konrad...
> CC-ing Michael.
>
> Michael, since Fedora is using systemd, did you observe this bug as well?
> (I think I did, but I might have blamed it on my wacky setup).
I only tried the xen systemd on xen 4.5-rc2 and didn't have a lot of 
success even when I reverted to Fedora's systemd for xen, so I can't 
really comment. I did have issues with xen systemd which I shall report if 
they are still there in -rc3.
        Michael Young

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel