[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] tools/hotplug: update systemd dependency to use service instead of socket
On Tue, 2014-12-02 at 16:39 +0100, Olaf Hering wrote: > Since commit 4542ae340d75bd6319e3fcd94e6c9336e210aeef ("tools/hotplug: > systemd xenstored dependencies") all service files use the .socket unit > as startup dependency. While this happens to work for boot it fails for > shutdown because a .socket does not seem to enforce ordering. When > xendomains.service runs during shutdown then systemd will stop > xenstored.service at the same time. > > Change all "xenstored.socket" to "xenstored.service" to let systemd know > that xenstored has to be shutdown after everything else. > > Reported-by: Mark Pryor <tlviewer@xxxxxxxxx> > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx> > --- > > This should go into 4.5 to fix xendomains.service. CCing Konrad... > > tools/hotplug/Linux/systemd/xen-init-dom0.service.in | 4 ++-- > tools/hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service.in | 4 ++-- > tools/hotplug/Linux/systemd/xenconsoled.service.in | 4 ++-- > tools/hotplug/Linux/systemd/xendomains.service.in | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/tools/hotplug/Linux/systemd/xen-init-dom0.service.in > b/tools/hotplug/Linux/systemd/xen-init-dom0.service.in > index 4d4cb23..3befadc 100644 > --- a/tools/hotplug/Linux/systemd/xen-init-dom0.service.in > +++ b/tools/hotplug/Linux/systemd/xen-init-dom0.service.in > @@ -1,7 +1,7 @@ > [Unit] > Description=xen-init-dom0, initialise Dom0 configuration (xenstore nodes, > JSON configuration stub) > -Requires=xenstored.socket proc-xen.mount > -After=xenstored.socket proc-xen.mount > +Requires=xenstored.service proc-xen.mount > +After=xenstored.service proc-xen.mount > ConditionPathExists=/proc/xen/capabilities > > [Service] > diff --git > a/tools/hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service.in > b/tools/hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service.in > index 6b9c96e..0a5807a 100644 > --- a/tools/hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service.in > +++ b/tools/hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service.in > @@ -1,7 +1,7 @@ > [Unit] > Description=qemu for xen dom0 disk backend > -Requires=proc-xen.mount xenstored.socket > -After=proc-xen.mount xenstored.socket xenconsoled.service > +Requires=proc-xen.mount xenstored.service > +After=proc-xen.mount xenstored.service xenconsoled.service > Before=xendomains.service libvirtd.service libvirt-guests.service > RefuseManualStop=true > ConditionPathExists=/proc/xen/capabilities > diff --git a/tools/hotplug/Linux/systemd/xenconsoled.service.in > b/tools/hotplug/Linux/systemd/xenconsoled.service.in > index 2c5d99f..cb44cd6 100644 > --- a/tools/hotplug/Linux/systemd/xenconsoled.service.in > +++ b/tools/hotplug/Linux/systemd/xenconsoled.service.in > @@ -1,7 +1,7 @@ > [Unit] > Description=Xenconsoled - handles logging from guest consoles and hypervisor > -Requires=proc-xen.mount xenstored.socket > -After=proc-xen.mount xenstored.socket > +Requires=proc-xen.mount xenstored.service > +After=proc-xen.mount xenstored.service > ConditionPathExists=/proc/xen/capabilities > > [Service] > diff --git a/tools/hotplug/Linux/systemd/xendomains.service.in > b/tools/hotplug/Linux/systemd/xendomains.service.in > index 757278f..9962671 100644 > --- a/tools/hotplug/Linux/systemd/xendomains.service.in > +++ b/tools/hotplug/Linux/systemd/xendomains.service.in > @@ -1,7 +1,7 @@ > [Unit] > Description=Xendomains - start and stop guests on boot and shutdown > -Requires=proc-xen.mount xenstored.socket > -After=proc-xen.mount xenstored.socket xenconsoled.service > xen-init-dom0.service > +Requires=proc-xen.mount xenstored.service > +After=proc-xen.mount xenstored.service xenconsoled.service > xen-init-dom0.service > ConditionPathExists=/proc/xen/capabilities > > [Service] > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxx > http://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |