[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH for-4.5 2/3] python/xc: Fix multiple issues in pyxc_readconsolering()
On Tue, Dec 02, 2014 at 01:50:37PM +0000, Ian Campbell wrote: > On Mon, 2014-12-01 at 16:14 -0500, Konrad Rzeszutek Wilk wrote: > > On Fri, Nov 28, 2014 at 11:38:52AM +0000, Ian Campbell wrote: > > > On Thu, 2014-11-27 at 12:34 +0000, Andrew Cooper wrote: > > > > Don't leak a 16k allocation if PyArg_ParseTupleAndKeywords() or the > > > > first > > > > xc_readconsolering() fail. It is trivial to run throught the processes > > > > memory > > > > by repeatedly passing junk parameters to this function. > > > > > > > > In the case that the call to xc_readconsolering() in the while loop > > > > fails, > > > > reinstate str before breaking out, and passing a spurious pointer to > > > > free(). > > > > > > > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > > > > Coverity-IDs: 1054984 1055906 > > > > CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx> > > > > CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> > > > > CC: Wei Liu <wei.liu2@xxxxxxxxxx> > > > > CC: Xen Coverity Team <coverity@xxxxxxx> > > > > > > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> > > > > Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> > > Did you intend to also ack patch #1? (or have I missed a mail?) No. You two still were discussing it so I figured I will wait until a repost. > > > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |