[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] Xen 4.5 development update (September update). Feature freeze slip by two weeks.
- To: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
- From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
- Date: Thu, 25 Sep 2014 17:26:31 -0400
- Cc: "artem.mygaiev@xxxxxxxxxxxxxxx" <artem.mygaiev@xxxxxxxxxxxxxxx>, "msw@xxxxxxxxxx" <msw@xxxxxxxxxx>, "gross@xxxxxxxx" <gross@xxxxxxxx>, "dongxiao.xu@xxxxxxxxx" <dongxiao.xu@xxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxx>, "mengxu@xxxxxxxxxxxxx" <mengxu@xxxxxxxxxxxxx>, "chao.p.peng@xxxxxxxxxxxxxxx" <chao.p.peng@xxxxxxxxxxxxxxx>, "zhigang.x.wang@xxxxxxxxxx" <zhigang.x.wang@xxxxxxxxxx>, "parth.dixit@xxxxxxxxxx" <parth.dixit@xxxxxxxxxx>, "Paul.Skentzos@xxxxxxxxxxxxxxx" <Paul.Skentzos@xxxxxxxxxxxxxxx>, "wency@xxxxxxxxxxxxxx" <wency@xxxxxxxxxxxxxx>, "rcojocaru@xxxxxxxxxxxxxxx" <rcojocaru@xxxxxxxxxxxxxxx>, "guijianfeng@xxxxxxxxxxxxxx" <guijianfeng@xxxxxxxxxxxxxx>, "daniel.kiper@xxxxxxxxxx" <daniel.kiper@xxxxxxxxxx>, "josh.whitehead@xxxxxxxxxxxxxxx" <josh.whitehead@xxxxxxxxxxxxxxx>, Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>, "avanzini.arianna@xxxxxxxxx" <avanzini.arianna@xxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "serge.broslavsky@xxxxxxxxxx" <serge.broslavsky@xxxxxxxxxx>, "feng.wu@xxxxxxxxx" <feng.wu@xxxxxxxxx>, "yjhyun.yoo@xxxxxxxxxxx" <yjhyun.yoo@xxxxxxxxxxx>, Thomas Leonard <talex5@xxxxxxxxx>, "olaf@xxxxxxxxx" <olaf@xxxxxxxxx>, "Steve.Vande.rLeest@xxxxxxxxxxxxxxx" <Steve.Vande.rLeest@xxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, "vijay.kilari@xxxxxxxxx" <vijay.kilari@xxxxxxxxx>, "mcgrof@xxxxxxxx" <mcgrof@xxxxxxxx>, "julien.grall@xxxxxxxxxx" <julien.grall@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "robert.vanvossen@xxxxxxxxxxxxxxx" <robert.vanvossen@xxxxxxxxxxxxxxx>, "shantong.kang@xxxxxxxxx" <shantong.kang@xxxxxxxxx>, "roy.franz@xxxxxxxxxx" <roy.franz@xxxxxxxxxx>, "yang.z.zhang@xxxxxxxxx" <yang.z.zhang@xxxxxxxxx>, Paul Durrant <Paul.Durrant@xxxxxxxxxx>, "ufimtseva@xxxxxxxxx" <ufimtseva@xxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, "andrii.tseglytskyi@xxxxxxxxxxxxxxx" <andrii.tseglytskyi@xxxxxxxxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, Dave Scott <Dave.Scott@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, "aravindp@xxxxxxxxx" <aravindp@xxxxxxxxx>, "suriyan.r@xxxxxxxxx" <suriyan.r@xxxxxxxxx>, Dario Faggioli <dario.faggioli@xxxxxxxxxx>, Eddie Dong <eddie.dong@xxxxxxxxx>, "Kelly.Zytaruk@xxxxxxx" <Kelly.Zytaruk@xxxxxxx>, "dslutz@xxxxxxxxxxx" <dslutz@xxxxxxxxxxx>, "tklengyel@xxxxxxxxxxxxx" <tklengyel@xxxxxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, "Aravind.Gopalakrishnan@xxxxxxx" <Aravind.Gopalakrishnan@xxxxxxx>, David Vrabel <david.vrabel@xxxxxxxxxx>, "Suravee.Suthikulpanit@xxxxxxx" <Suravee.Suthikulpanit@xxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "tiejun.chen@xxxxxxxxx" <tiejun.chen@xxxxxxxxx>, Malcolm Crossley <malcolm.crossley@xxxxxxxxxx>, "yanghy@xxxxxxxxxxxxxx" <yanghy@xxxxxxxxxxxxxx>, "Vijaya.Kumar@xxxxxxxxxxxxxxxxxx" <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>, "christoffer.dall@xxxxxxxxxx" <christoffer.dall@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 25 Sep 2014 21:26:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Thu, Sep 25, 2014 at 10:25:42AM +0100, George Dunlap wrote:
> On 09/25/2014 10:22 AM, Dave Scott wrote:
> >Hi Konrad,
> >
> >On 10 Sep 2014, at 18:05, <konrad.wilk@xxxxxxxxxx> <konrad.wilk@xxxxxxxxxx>
> >wrote:
> >
> >>* extend the xenstore ring with a 'closing' signal (fair)
> >> RFC patch posted
> >> - David Scott
> >Iâd like to propose an exception for this one. The title is perhaps
> >underselling it: although it is a protocol extension (and hence a new
> >feature) the main motivation is to fix a bug in hvmloader which causes HVM
> >guests to hang during booting on a busy machine. The bug is fairly easy to
> >reproduce with ~200 VMs: youâll probably find at least one failed to boot.
> >
> >The patch set has got to a v4 but needs a little bit of work to clarify the
> >relationship between the closing signal and the existing RESET_WATCHES
> >xenstore protocol request.
It looked (from a brief look) as it has OCaml and I have no experience
with that. Is there somebody who can review it?
I hadn't dug in it to give it yet an opinion (sorry).
> >
> >I may be pushing my luck here :-) but Iâd like to propose an additional
> >exception for a feature not on your list:
> >
> >* xl, libxl: add support for âchannels'
> >
> >This has got to a v6 and I believe the API and implementation is stable. It
> >mainly needs some review of the xl config file parsing changes. This is
> >definitely a new feature and not a bug fix. Iâd mainly like to make the API
> >official so that I can depend upon it in libvirt.
> >
> >Thanks for your consideration!
>
> I think a release exception is like an Acked-by or a Reviewed-by: it applies
> to a specific version of a patch series, not the general idea of the patch
> series. There's no point arguing for a release exception until you actually
> have an otherwise fully-Acked patch series.
This is going to hard decision. I looked over the patches and while I had minor
comments - the toolstack maintainers MUST also Ack it.
I am not yet sure whether to give it an exception or not so please don't
treat my comments as endorsment - I just needed to understand the code
and think about the ramifications along with the maintainers opionions.
>
> -George
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
