Re: [Xen-devel] [PATCH 32/46] Add configure --with-linux-backend-modules="mod1 mod2"

[Olaf Hering <olaf@xxxxxxxxx>]

On Tue, Sep 23, Ian Campbell wrote:

> On Mon, 2014-09-22 at 15:00 +0200, Olaf Hering wrote:
> > +LINUX_BACKEND_MODULES="`eval echo $LINUX_BACKEND_MODULES`"
> 
> Why does this need to be laundered via eval? There's no sensible way a
> user could want to pass in \$thing and expect it to expand to something
> useful, is there?

I decided to use a multiline assignment to make futher patches to the
content easier to read. If the variable is expanded it will appear as is
in the Makefile, resulting in syntax errors. Maybe a single echo would
work as well. 
Will check if this can be improved. But I fear there is not much that
can be done to achieve "\$thing".

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel