Re: [Xen-devel] [PATCH 32/46] Add configure --with-linux-backend-modules="mod1 mod2"

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-09-22 at 15:00 +0200, Olaf Hering wrote:
> This replaces config/Linux.modules with a configure option. As a result
> of this change only a single xencomons.in is required, instead of a
> xencomons.in.in and sed hackery.

I think the change wrt which blktap modules are loaded deserves
mentioning here, since it is a functional change. It's almost worth
making that trivial sounding change separately, in case there are
knockon effects.

Yay to the lack of sed hackery though!

> +LINUX_BACKEND_MODULES="
> +xen-evtchn
> +xen-gntdev
> +xen-gntalloc
> +xen-blkback
> +xen-netback
> +xen-pciback
> +evtchn
> +gntdev
> +netbk
> +blkbk
> +xen-scsibk
> +usbbk
> +pciback
> +xen-acpi-processor
> +blktap2
> +blktap
> +"
> +;;
> +*)
> +LINUX_BACKEND_MODULES=
> +;;
> +esac])
> +LINUX_BACKEND_MODULES="`eval echo $LINUX_BACKEND_MODULES`"

Why does this need to be laundered via eval? There's no sensible way a
user could want to pass in \$thing and expect it to expand to something
useful, is there?

> diff --git a/tools/hotplug/Linux/systemd/Makefile 
> b/tools/hotplug/Linux/systemd/Makefile
> index dc98b67..ac20c76 100644
> --- a/tools/hotplug/Linux/systemd/Makefile
> +++ b/tools/hotplug/Linux/systemd/Makefile
> [...]
> +$(XEN_SYSTEMD_MODULES):
> +     for mod in $(LINUX_BACKEND_MODULES) ; do \
> +             echo $$mod ; \
> +             done > $@.tmp ; \
> +     $(call move-if-changed,$@.tmp,$@)

No need for "; \" before the call, I think.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel