Re: [Xen-devel] [RFC Patch v4 8/9] store correct format into tapdisk-params/params

[Wen Congyang <wency@xxxxxxxxxxxxxx>]

On 09/23/2014 06:11 PM, Ian Campbell wrote:
> On Tue, 2014-09-23 at 10:07 +0800, Wen Congyang wrote:
>> On 09/22/2014 10:37 PM, Ian Campbell wrote:
>>> On Mon, 2014-09-22 at 13:59 +0800, Wen Congyang wrote:
>>>
>>>> And we cannot use the API libxl_disk_format_from_string()
>>>> to get the format from the string.
>>>
>>> ... can you spell out why/where this is important please.
>>
>> The API libxl_device_disk_list() will return all disks. But the
>> type is wrong if it is a tapdisk device.
> 
> Thanks, please add this to the commit message.

OK

> 
>>>
>>> Did you test blktap2 and qemu to be sure that they handle "raw" in
>>> particular correctly?
>>
>> Sorry, I don't understand what do you want to test.
> 
> That both blktap2 and qemu still correctly handle raw disk images after
> your changes, since AIUI the xenstore contents will have changed for
> them.

OK, I will check it

Thanks
Wen Congyang

> 
> Ian.
> 
> .
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel