Re: [Xen-devel] [PATCH 32/46] Add configure --with-linux-backend-modules="mod1 mod2"

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-09-23 at 12:36 +0200, Olaf Hering wrote:
> On Tue, Sep 23, Ian Campbell wrote:
> 
> > On Mon, 2014-09-22 at 15:00 +0200, Olaf Hering wrote:
> > > This replaces config/Linux.modules with a configure option. As a result
> > > of this change only a single xencomons.in is required, instead of a
> > > xencomons.in.in and sed hackery.
> > 
> > I think the change wrt which blktap modules are loaded deserves
> > mentioning here, since it is a functional change. It's almost worth
> > making that trivial sounding change separately, in case there are
> > knockon effects.
> 
> At least systemd would load blktap2 and blktap via xen.conf. And the
> SUSE xencommons also loads both drivers. So I think they can coexist.
> No sure what the intent of the initial "modprobe blktap2 || modprobe
> blktap" was. I think doing it that way did not solve a real bug. The
> comments in the discussion at that time did not provide a hint that a
> bug was fixed.

That's fine, and the sort of thing I'd like to see the commit message
say so we know in 6 months time why this was subtly changed in the midst
of another change.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel