[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v8 0/6] xen: systemd support
On Wed, 2014-07-30 at 18:43 +0200, Luis R. Rodriguez wrote: > On Wed, Jul 30, 2014 at 05:25:40PM +0100, Ian Campbell wrote: > > On Wed, 2014-07-30 at 18:22 +0200, Luis R. Rodriguez wrote: > > > > > > Also, you should probably invoke the script with $(BASH), else IIRC you > > > > will break *BSD (where bash is in ports not /bin) > > > > > This is a Linux script though, > > > > True. > > > > > I'll use #!/usr/bin/env bash > > > instead then. > > > > That's worse than either $(BASH) or a normal #! IMHO. > > Do you mean to call $BASH foo.sh on the makefile ? I meant $(BASH), or perhaps $(SHELL), but yes. > On Linux we can run scripts often on Makefiles with > either #!/bin/bash or the env thing just fine. I've > never actually have seen the use of $(BASH) foo.sh > within the Makefile. Yes, it seems like you are right and we don't do this. I suppose because all such #! lines are in Linux specific bits of the build. Sorry, I guess I was confused by the presence of $(BASH) at all, combined with the fact that we do jump through similar hoops for $(PYTHON). So lets leave it as #! /bin/bash which appears to be the predominant style. > I promise to address issues > if found with this approach. Thanks. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |