Re: [Xen-devel] [PATCH v8 0/6] xen: systemd support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-07-28 at 19:57 +0200, Luis R. Rodriguez wrote:
> On Mon, Jul 28, 2014 at 04:05:51PM +0100, Ian Campbell wrote:
> > On Mon, 2014-07-28 at 17:02 +0200, Luis R. Rodriguez wrote:
> > > On Mon, Jul 28, 2014 at 01:46:32PM +0100, Ian Campbell wrote:
> > > > On Fri, 2014-07-25 at 19:14 -0700, Luis R. Rodriguez wrote:
> > > > > From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> > > > > 
> > > > > Here's my v8 series. Quite a bit of patches are alreayd merged
> > > > > on the xen origin/staging branch, this addresses the last feedback
> > > > > from the v7 series and is rebased. It contains two fixes spotted
> > > > > as possible issues by Ian Campbell.
> > > > > 
> > > > > I think this is it, after about 2 months of spinning patches. Phew.
> > > > 
> > > > I was about to ack and apply the lot when I noticed that
> > > > dist/install/etc/init.d/xencommons was an empty file.
> > > 
> > > The file tools/hotplug/Linux/update-modules.sh must be chmod 755
> > 
> > I observed the git diff had the mode in it, so I assumed that git am
> > would have done the right thing. I didn't check directly but I did look
> > at the build log which didn't show it failing to run the script (which
> > in any case should have caused the build to fail)
> > 
> > > and I thought I did that on the series, I just double checked and
> > > it is indeed in the right mode on the v8 patch so not sure what
> > > could have gone wrong here. Sorry about that I could have sworn
> > > I had tested that particular case... I'm pretty sure I did. Will
> > > reseting / poke around.
> > 
> > Thanks.
> 
> OK I see now what happed. In my tests I had exported XENCOMMONS_INITD
> locally to run and test the shell script from the shell and later
> make -C tools/hotplug/Linux. This worked as I exported it manually but
> without that we need to expicitly do that then on the Makefile now or
> pass it as an argument. Exporting seems easier. Will rebase and send
> last batch with this hunk merged.

I'd prefer the script to take this as an argument for clarity.

Also, you should probably invoke the script with $(BASH), else IIRC you
will break *BSD (where bash is in ports not /bin)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel