Re: [Xen-devel] [PATCH v2 10/18] tools/misc: introduce helper to initialise Dom0

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-07-30 at 19:23 +0100, Wei Liu wrote:

I don't think I'm going to have a chance to review this series in detail
but I noticed two little things while skimming:

> +    xch = xc_interface_open(0, 0, 0);
> +    if (!xch) {
> +        fprintf(stderr, "cannot open libxc handle\n");
> +        exit(1);
> +    }

AFAICT you don't do anything with this apart from closing it again.

> +    rc = libxl_userdata_store(ctx, 0, "libxl-json",
> +                              (const uint8_t *)json,
> +                              strlen(json) + 1 /* inlcude '\0' */);

"include"

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel